Le 22/11/2018 à 22:45, Xavier a écrit : > Le 22/11/2018 à 21:06, Xavier a écrit : >> Le 22/11/2018 à 10:19, Xavier a écrit : >>> Le 22/11/2018 à 08:46, Raphael Hertzog a écrit : >>>> Hi, >>>> >>>> On Wed, 21 Nov 2018, Xavier wrote: >>>>> Sorry, I found a SALSA_TEAM in your conf file. For clarity, SALSA_TEAM >>>>> has been replaced by SALSA_GROUP (same for all team commands/options >>>>> replaced by *group*). >>>> >>>> Working much better with SALSA_GROUP ;) But then I got this: >>>> >>>> wapiti: >>>> bad irc channel: #debian-pkg-security >>>> >>>> It was really not clear what was wrong. But it seems that you expect: >>>> SALSA_IRC_CHANNEL=debian-pkg-security >>>> >>>> And not the value that I had put initially: >>>> SALSA_IRC_CHANNEL=#debian-pkg-security >>>> >>>> It seems strange to require to strip the leading hash. I would rather >>>> be more user-friendly: add the leading hash if it's missing, but otherwise >>>> assume that the value is the full name (some channels can start with two >>>> leading hashes). Also the documentation should be clear on this. >> >> I updated doc for this (also explanation that "#" is considered as >> comment by "sh"). Spelling errors also fixed, thanks ! >> >>> Hello, >>> >>> this is due to sh. This diff explains more: >>> diff --git a/scripts/salsa.pl b/scripts/salsa.pl >>> index 52a174bb..d1751ecf 100755 >>> --- a/scripts/salsa.pl >>> +++ b/scripts/salsa.pl >>> @@ -567,9 +567,19 @@ C<.devscripts> values: B<SALSA_ENABLE_MR> >>> (yes/ignore/no, default: ignore) >>> >>> =item B<--irc-channel> >>> >>> -IRC channel for KGB or Irker. >>> +IRC channel for KGB or Irker. Can me used more than one time only with >>> +B<--irker>. >>> >>> -C<.devscript> value: B<SALSA_IRC_CHANNEL> >>> +B<Important>: channel must not include the first "#". If salsa find a >>> channel >>> +starting with "#", it will consider that channel starts with 2 "#"! >>> + >>> +C<.devscript> value: B<SALSA_IRC_CHANNEL>. >>> + >>> +Multiple values must be space separated. >>> + >>> +Since configuration files are read using B<sh>, be careful when using >>> "#": you >>> +must enclode the channel with quotes, else B<sh> will consider it as a >>> comment >>> +and will ignore this value. >>> >>> =item B<--irker>, B<--no-irker>, B<--disable-irker> >>> >>>> Another detail I noticed, the values of SALSA_EMAIL_RECIPIENTS should >>>> benefit >>>> from the same substitution as SALSA_DESC_PATTERN so that we can include the >>>> name of the repo in the generated email addresses. >>> >>> OK, I'm going to do this >> >> Done. Hope salsa works fine now ;-) >> .deb updated >> >> Cheers, >> Xavier > > Last .deb contains the SALSA_RENAME_HEAD. Could you test it ? > > Cheers, > Xavier
One important thing: I set ruprecht.snow-crash.org as default value for --irker-host. Is it a good idea ? Is this server secured [1] ? [1]: http://www.catb.org/~esr/irker/security.html
