Package: broctl
Version: 1.4-1
Severity: normal
User: m...@linux.it
Usertags: usrmerge
Tags: patch

Dear Maintainer,

The package currently fails to build reproducibly on merged-usr vs
non-merged systems. This is because the build systems InstallShellScript
macro rewrites shebangs by looking up things via PATH which can lead
to picking up unwanted paths (eg. /usr/local/bin/bash).

The upstream build system has already identified this problem and
provides a configure flag to disable the rewriting: --binary-package

Unfortunately it seems dh doesn't use the provided configure script
but invokes CMake directly, thus I had to define the "internal" symbol
that --binary-package sets: -DBINARY_PACKAGE_MODE=true

Please see the attached patch that fixes this bug report.

Regards,
Andreas Henriksson
diff -Nru broctl-1.4/debian/changelog broctl-1.4/debian/changelog
--- broctl-1.4/debian/changelog 2015-10-30 23:33:09.000000000 +0100
+++ broctl-1.4/debian/changelog 2018-12-07 20:21:42.000000000 +0100
@@ -1,3 +1,11 @@
+broctl (1.4-1.1) UNRELEASED; urgency=medium
+
+  * Non-maintainer upload.
+  * Use --binary-package configure flag to avoid rewriting files
+    - fixes reproducible build on merged-usr vs non-merged systems
+
+ -- Andreas Henriksson <andr...@fatal.se>  Fri, 07 Dec 2018 20:21:42 +0100
+
 broctl (1.4-1) unstable; urgency=medium
 
   * New upstream version
diff -Nru broctl-1.4/debian/rules broctl-1.4/debian/rules
--- broctl-1.4/debian/rules     2015-10-30 23:13:44.000000000 +0100
+++ broctl-1.4/debian/rules     2018-12-07 20:21:42.000000000 +0100
@@ -11,7 +11,8 @@
 override_dh_auto_configure:
        dh_auto_configure -- \
        -DBRO_ETC_INSTALL_DIR=/etc/bro -DBRO_SCRIPT_INSTALL_PATH=/usr/share/bro 
\
-       -DBRO_SPOOL_DIR=/var/spool/bro -DBRO_LOG_DIR=/var/log/bro
+       -DBRO_SPOOL_DIR=/var/spool/bro -DBRO_LOG_DIR=/var/log/bro \
+       -DBINARY_PACKAGING_MODE=true
 
 override_dh_install:
        dh_install --fail-missing

Reply via email to