Control: tags -1 patch fixed-upstream On Sun, 09 Dec 2018 12:27:44 +0200 Adrian Bunk <[email protected]> wrote: > Source: unyaffs > Version: 0.9.6-1 > Severity: serious > Tags: ftbfs buster sid > > https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/unyaffs.html > > ... > make V=1 -j1 > make[2]: Entering directory '/build/1st/unyaffs-0.9.6' > cc -D_FORTIFY_SOURCE=2 -O2 -Wall -Wl,-z,relro unyaffs.c -o unyaffs > unyaffs.c: In function 'prt_node': > unyaffs.c:360:15: warning: implicit declaration of function 'major' > [-Wimplicit-function-declaration] > major(oh->yst_rdev), > ^~~~~ > unyaffs.c:361:15: warning: implicit declaration of function 'minor'; did you > mean 'mknod'? [-Wimplicit-function-declaration]
Hi, This is fixed upstream in version 0.9.7. https://github.com/ehlers/unyaffs/commit/51f84b5e I've attached a patch based on that but with less noise. The reason for breakage is mentioned in glibc 2.28 changelog. https://lists.gnu.org/archive/html/info-gnu/2018-08/msg00000.html "The macros 'major', 'minor', and 'makedev' are now only available from the header <sys/sysmacros.h>" Regards, Juhani
Description: Fix FTBFS with glibc 2.28 https://lists.gnu.org/archive/html/info-gnu/2018-08/msg00000.html: "The macros 'major', 'minor', and 'makedev' are now only available from the header <sys/sysmacros.h>" Origin: https://github.com/ehlers/unyaffs/commit/51f84b5e80f98e5df531df0be85e7e75b2cd038f Bug-Debian: https://bugs.debian.org/915997 --- a/unyaffs.c +++ b/unyaffs.c @@ -61,6 +61,9 @@ #include <stdarg.h> #include <time.h> #include <errno.h> +#if defined(__linux__) || defined(__GLIBC__) +#include <sys/sysmacros.h> +#endif #ifdef HAS_LUTIMES #include <sys/time.h> #else
