[EMAIL PROTECTED] wrote:
I think that's reasonable.  Having a propdel result in a textual diff
is rather unexpected, and in some sense the in-file expanded portion
of the keyword is "part of" the property.  We'll have to do it
carefully, of course, because the working file might have local mods.

CAVEAT: Not a developer, but someone interested in keywords in general.

Personally I think it would be _much_ more surprising to automatically unexpand the keyword when the matching property is deleted. If someone sets one of the expanding properties and the unsets it, either they made a mistake in the first place (and should revert that expanded text on their own) or they meant to do that to freeze the expanded text (and hence the diff is completely legit).

For example, a site policy is that all new files are to be created with svn:keywords "Author" set and then committed. Then, the svn:keywords "Author" is to be removed and the file committed again, thus orphaning the original Author information in the file for all time. Sure this is stupid, but it does correspond to some behavior that has been used in CVS in the past (although there I believe it was freezing $Id$ on tags).

My 2 cents

John

--
John Peacock
Director of Information Research and Technology
Rowman & Littlefield Publishing Group
4501 Forbes Boulevard
Suite H
Lanham, MD  20706
301-459-3366 x.5010
fax 301-429-5748


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to