On 1/5/19 7:26 PM, Jörg-Volker Peetz wrote: > Package: zstd > Version: 1.3.8+dfsg-2 > Severity: normal > > Dear Maintainer(s), > > the search command zstdgrep always returns an exit code of 1 when > called with file name(s). > The logic with EXIT_CODE and CUR_EXIT_CODE in that shell script seems > bogus to me. Shouldn't something simple like > > EXIT_CODE=0 > ... > [ "$?" -ne 0 ] && EXIT_CODE=1 > ... > > work? > I attach a patch which also corrects a minor nit regarding the *egrep and > *fgrep > variants. > > Regards, > Jörg. > > > _______________________________________________ > Debian-med-packaging mailing list > debian-med-packag...@alioth-lists.debian.net > https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/debian-med-packaging >
Thank you for the patch. however I didn't apply the change for zegrep/zfgrep, because I don't see how this can be problematic. We will have a conflict if zstd will start shipping zfgrep and zegrep which is also provided by gzip and zutils. But for now I leave it as it is. Best regards, Alex
