On 10/01/19 18:05, Santiago Vila wrote: > Package: src:fasm > Version: 1.73.06-1 > Severity: serious > Tags: patch > > Dear maintainer: > > Commands in a Makefile should be chained with "&&" so that the first > thing which fails makes the whole process to stop. > > This is Policy 4.6, "error trapping in makefiles", and it's usually considered > a serious issue: > > https://www.debian.org/doc/debian-policy/ch-source.html#error-trapping-in-makefiles > > Proposed patch below. > > Unfortunately, the patch will not make the package to build again and > it needs to be "bootstrapped" again (my theory is that the package was > misbuilt > the last time because of this, but I'm not completely sure). > > Would not be possible to build the program using the standard assembler? > I would do that if possible, that way we could eliminate the > build-dependency on itself. > > Thanks. > > --- a/debian/rules > +++ b/debian/rules > @@ -8,7 +8,7 @@ include /usr/share/dpkg/default.mk > > override_dh_install: > mkdir -p debian/tmp > - (cd source/libc; fasm fasm.asm; gcc $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) > -m32 fasm.o -o fasm) > + cd source/libc && fasm fasm.asm && gcc $(CFLAGS) $(CPPFLAGS) $(LDFLAGS) > -m32 fasm.o -o fasm > > override_dh_clean: > dh_clean
Oh... I removed dh_install from the override in https://salsa.debian.org/debian/fasm/commit/390c9ea515e788c5bf422fa3b5ba99a64f3caf5f. Stupid me! Ok, let's reboostrap the whole thing.
signature.asc
Description: PGP signature
