Package: winff
Version: 1.5.5-5
Severity: minor

Problem:

The package description of the binary package winff states:

|  This package is a metapackage to pull in either the GTK+ or Qt variant.

This is not exactly correct due to somewhat implicit action of debhelper
to include /usr/share/applications/winff.desktop to winff package.

Also, the desktop file mentions "avconv" while current situation
uses FFmpeg and it is gtk even when it calls winff-qt.

Background:

When I installed only winff-gtk2 trusting package description of winff,
winff didn't have GUI staring entry point.  After looking into the
git source at https://salsa.debian.org/pascal-team/winff, I realize it
only has winff.desktop.  I see the problem.

Possible solution.

Option 1 (simple but sloppy fix):
Since winff-data is always called in by the dependency, move
winff.desktop to winff-data package.  This can be done simply by
renaming debian/winff.desktop to winff-data.desktop

 ... this is easier but Category becomes incorrect for QT package

Option 2 (good fix):
Make winff-gtk2 and winff-qt package to contain desktop file of the
respective package.  For this, remove debian/winff.desktop and add:

debian/winff-gtk2.desktop

[Desktop Entry]
Version=1.0
Name=WinFF
Comment=GUI for FFmpeg
MimeType=application/winff;
Exec=winff-gtk2 %f
Icon=winff
Terminal=false
Type=Application
Categories=AudioVideo;AudioVideoEditing;GTK;
Keywords=avconv;ffmpeg;wrapper;conversion;video;audio;
GenericName=Video converter
GenericName[en]=Video converter
GenericName[nl]=Video converteerder


debian/winff-gtk2.qt

[Desktop Entry]
Version=1.0
Name=WinFF
Comment=GUI for FFmpeg
MimeType=application/winff;
Exec=winff-qt %f
Icon=winff
Terminal=false
Type=Application
Categories=AudioVideo;AudioVideoEditing;QT;
Keywords=avconv;ffmpeg;wrapper;conversion;video;audio;
GenericName=Video converter
GenericName[en]=Video converter
GenericName[nl]=Video converteerder

Here, I fixed FFmpeg thing and QT thing.

Regards,

Osamu

-- System Information:
Debian Release: buster/sid
  APT prefers testing
  APT policy: (500, 'testing'), (10, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 4.19.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages winff depends on:
ii  winff-gtk2  1.5.5-5

winff recommends no packages.

winff suggests no packages.

-- no debconf information

Reply via email to