OP here,

Am So, 13. Jan 2019 um 14:49:06 +0100 schrieb Gianfranco Costamagna:
On Sun, 13 Jan 2019 13:29:13 +0100 drake763 <drake...@googlemail.com> wrote:
2) The fix in 2.6.1-3 produces (when creating a deb package) a package
named PACKAGENAME_amd64.deb, where amd64 is my compiling computer's
architecture. However, it was my understanding that dkms created debs
should have *_all.deb as a naming convention? But this may well be a
misunderstanding on my side.
Now, dkms run on amd64 produces binaries for *amd64* architecture, and if you run the same command on i386 you will produce kernel modules that can run only on *i386* architecture

For binary packages that's what I would expect. So dkms does the right thing.

*all* is a suffix used when the built artifacts are the same in every architecture (e.g. an image, a pdf, an html file, a documentation package, that is the same everywhere).

Having _all.deb was a mistake on the module generation, because the same file would have had no information about its content, and would have been called exactly the same on different architectures.

So, I'm confident enough that the fix now is "correct", and I hope somebody else would ack my changes, because I'm not a direct user of this feature, so my blind fix might have been incorrectly applied.

In my case I use dkms --source-only. The package does not contain arch specific binaries but with the current dkms version the result will also get the arch suffix. I would have expected the package to contain a non-arch suffix as there is no need for such a thing in that case. But I also don't mind if the current behaviour stays. It still works for me.

Regards,
Dirk

Reply via email to