Hi Chris,
On Sun, Jan 20, 2019 at 10:23:35PM +0000, Chris Lamb wrote:
> Very happy to upload that as-is. However, on a regular build this does not
> make any difference:
>
> # Build the non-bundled Lua libraries
> /usr/bin/make -C deps/lua/src lua_struct.o lua_cmsgpack.o
> make[2]: Entering directory '/tmp/buildd/redis-5.0.3/deps/lua/src'
> cc -O2 -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -c -o lua_struct.o
> lua_struct.c
> cc -O2 -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -c -o lua_cmsgpack.o
> lua_cmsgpack.c
>
> ... and after applying the patch:
>
> dh_auto_build --sourcedirectory=deps/lua/src -- lua_struct.o
> lua_cmsgpack.o
> cd deps/lua/src && make -j9 "INSTALL=install --strip-program=true"
> lua_struct.o lua_cmsgpack.o
> make[2]: Entering directory '/tmp/buildd/redis-5.0.3/deps/lua/src'
> cc -O2 -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -c -o lua_struct.o
> lua_struct.c
> cc -O2 -Wall -Wdate-time -D_FORTIFY_SOURCE=2 -c -o lua_cmsgpack.o
> lua_cmsgpack.c
>
> How does this change (in a concrete sense) when cross-building?
This is fully intentional. Some upstreams do weired things with ${CC}
and things. Having debhelper replace these variables could cause (rare)
FTBFS. Therefore debhelper supplies the relevant variables only when the
build architecture differs from the host architecture. If you perform a
cross build, you'll notice that the make invocation carries CC=..
CXX=... and PKG_CONFIG=...
Not breaking other people's stuff has been high on my priority list. :)
Helmut
