Hi Tobias, > So, ok; but this is not a reason to say: > > Upstream Author : Carlos Donizete Froes <corin...@riseup.net> > > in #919540 and setting your gitlab repository as upstream repository in > the packaging. Actually, this is misleading and I also find this unfair > to Michael Pavone. > You can really alienate upstreams by claiming their work > is yours. You surely understand that this is bad and against the > spirit of Open Source and Debian.
Now I completely understand what you're telling me, honestly, it was an oversight on my part, I did not mean to do that. My biggest reason is to help the upstream get their software in Debian. I do this for love and I do not want to undermine the work of the original author. > From the posted mails in #919540 I cannot see that upstream agreed to > move everything to your repository, his words were, which IMHO as quite > different meaning and does not even touch the topic you seem to read out > of it: > "I realize Mercurial is a bit unfashionable these days, but I believe > there is a bridge that allows git to interop with it. Pulling from the > public repo will make it easier for me to accept your changes upstream. > Assuming that's what you want anyway." > > (And I wonder why you set the gitlab as upstream repository, while you > seem to collaborate on github) I would like GitLab to have an easy way to import the Mercurial repository. The only way to get it is by GitHub, which has this import function from hg to git. And then I would be able to import into my GitLab account. I know this is crazy, but the only way to start my work in packaging. I do not use GitHub, I had previous problems with my password, just to import hg to git, if you have another way to import into GitLab, please I'm here to learn and fix my errors. > I did a complete diff against upstream [1] and your repo [2], both > "trunk" for that. And the only behaviourl change seems to be > > --- blastem-ba3fb7a3be6b/zlib/gzlib.c 2019-01-23 06:15:38.000000000 +0100 > +++ blastem/zlib/gzlib.c 2019-01-25 20:15:47.852968532 +0100 > @@ -291,6 +291,7 @@ > gzFile gz; > > if (fd == -1 || (path = (char *)malloc(7 + 3 * sizeof(int))) == NULL) > + free(path); > return NULL; > #if !defined(NO_snprintf) && !defined(NO_vsnprintf) > (void)snprintf(path, 7 + 3 * sizeof(int), "<fd:%d>", fd); > diff -Naur blastem-ba3fb7a3be6b/zlib/trees.c blastem/zlib/trees.c > > (which introduces a bug, as the return is no longer conditional.) > > So either I'm right and there are no siginifant changes, or upstream has > merged everything you have provided, but that means that upstream is [2] > not you. > > [1] https://gitlab.com/coringao/blastem > [2] https://www.retrodev.com/repos/blastem I am sorry to inform you, but it was not only that, after working with the packaging, there were several simple bugs and warnings that I needed to correct: - I have changed some files with executable permission.[1] - Fixed a warning I was not finding on the line.[2] - Fixed the typing error, this is because when doing a 'debuild', the warning appears in lintian in the generated binary.[3] - Added -g in GCC to appear debug information during compilation.[4] - Commented the file 'test.c', where an error occurred during debuild.[5] [1] https://gitlab.com/coringao/blastem/commit/5a4a48dd763aacd788c340b6a2d9f92f841ad1ee [2] https://gitlab.com/coringao/blastem/commit/9dadd76de5759c1fd7a150d42263b1782d717df9 [3] https://gitlab.com/coringao/blastem/commit/e8c58c4fe20323c90d486bdcd8c7f6321d96e538 [4] https://gitlab.com/coringao/blastem/commit/3b697e6d38e5c872dac5f88b82baac448718805a [5] https://gitlab.com/coringao/blastem/commit/490b40f5d765a0dbf9354a2ea2697ed9e140abf8 > Then do not claim being the upstream author in the first place. As I said at the beginning, it is not my intention, it was a mistake on my part and I will correct it. > Ok, then this is an good occasion to fix those issues. Yes, I am making this correction immediately. Thanks! -- ⢀⣴⠾⠻⢶⣦⠀ Carlos Donizete Froes [a.k.a coringao] ⣾⠁⢠⠒⠀⣿⡁ - https://wiki.debian.org/coringao ⢿⡄⠘⠷⠚⠋⠀ GPG: 4096R/B638B780 ⠈⠳⣄⠀⠀⠀ 2157 630B D441 A775 BEFF D35F FA63 ADA6 B638 B780
signature.asc
Description: This is a digitally signed message part
