On Sun, Jan 27, 2019 at 02:55:34PM +0100, Guilhem Moulin wrote: > Control: tag -1 pending > Control: notfound -1 1.105-1 > Control: found -1 1.195-1 > > Hi Peter, > > On Sun, 27 Jan 2019 at 12:38:54 +0200, Peter Pentchev wrote: > > I submitted a merge request on Salsa; what do you think about these > > changes to the Debian-specific patches that report the listening port in > > verbose mode? > > […] > > https://salsa.debian.org/debian/netcat-openbsd/merge_requests/1 > > Looks good, thanks! > > > The problem was introduced in the "Arbitrary port scan and more verbose > > information" change in netcat-openbsd-1.105-1: > > > > https://salsa.debian.org/debian/netcat-openbsd/commit/20f07991df0c84ffb395958b7d748f73c6e9a652 > > Hmm I can't reproduce this in Jessie nor Stretch, and AFAIK the problem > isn't present in that version, because a later patch in the series > replaces ‘%d’ with ‘%s’: > > > https://salsa.debian.org/debian/netcat-openbsd/commit/20f07991df0c84ffb395958b7d748f73c6e9a652#3b6b5277135c96ec76a42b9f9cb25e00e51a55e7_32_98
Oof, yeah, as you may have guessed, I only looked at this patch and didn't even try to actually test what `nc -l -v` would do... Thanks for the detective work there, and sorry if I made you wonder when you couldn't reproduce the problem! > That substitution was lost during a later refactoring, however: > > > https://salsa.debian.org/debian/netcat-openbsd/commit/0e821d987537ce643c2e0ad9a2ca061c4bf0efa5#5555896a9d96bb5aab3be772e3065fd1ed8fae77_322_112 Right, thanks. > That said 1.105-7 and later don't print out the right protocol family > number, and your patch fixes that too. Thanks! You're very welcome, and thanks for your work on Debian! G'luck, Peter -- Peter Pentchev roam@{ringlet.net,debian.org,FreeBSD.org} [email protected] PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
signature.asc
Description: PGP signature
