On 30/01/2019 14:04, Andrej Shadura wrote: > On 30/01/2019 13:54, Guido Günther wrote: >>> I have noticed gbp-dch started putting Signed-off-by fields into the >>> generated changelog. I don’t remember it doing so some time ago. >>> This happens at least from 0.9.10 onwards. >> >> It always did that if you don't set s.th. like >> >> [dch] >> ignore-regex = (Signed-off|Acked)-by: > >> So not a bug. Should the filtering not work please reopen and retitle >> appropriately. > > I disagree. Those tags should definitely not appear in debian/changelog, > I’d probably even say regardless of the user settings. It should be a > default in any case even if overridable.
Right: I never noticed this since I never used --full, and this package has it set in gbp.conf. Nevertheless, I think gbp should come with a default setting of ignore-regex = (Signed-off|Acked|Tested|Reviewed)-by:, I think that is sane to assume that if someone really really wants those in changelog they will override it. -- Cheers, Andrej
