Control: tags -1 + moreinfo On Thu, 18 Oct 2018 at 20:11:32 -0400, Chris Lamb wrote: > There is an issue where an initial "inline" directive would be > translated correctly but subsequent inlines of the same page would > result in the raw contents of the ".po" file (ie. starting with the raw > copyright headers!) being inserted into the page instead.
As noted on the upstream bug, I've added a failing test-case for this to ikiwiki. Unfortunately, I don't think either the patch on this bug or the patch sent upstream was correct: they introduce a cache that holds a large amount of wiki content in memory, which ikiwiki tries hard to avoid for performance, and I'm not confident that the cache is invalidated frequently enough for correctness. I have referenced an alternative solution (mostly code deletion) on the upstream bug. Please try: https://git.pseudorandom.co.uk/smcv/ikiwiki.git/commitdiff/wip/po-filter-every-time I would particularly appreciate review and testing from intrigeri, who wrote the code that I'm deleting and hopefully has a better picture of why it was/is necessary. (I would also like to have more extensive test coverage for the po plugin in general: I don't think any of the ikiwiki maintainers use it, so automated tests are the only way we can make sure it hasn't regressed.) Thanks, smcv
