On 2/8/19 2:47 AM, Dmitry Smirnov wrote: > On Friday, 8 February 2019 4:57:35 PM AEDT Antonio Russo wrote: >> At least on my setup, detect_xorg_setup(install_dir) in setup.py already >> produces >> >> xvfb_command[0] == '/usr/lib/xorg/Xorg' >> >> (around line 822 in setup.py). >> >> The assertion installed by our Debian specific patch does not consider >> that as a possibility. The attached updated patch relaxes the assertion, >> resolving the FTBFS. > > First of all let's not inflate the severity please. > > I could not reproduce FTBFS is pristine build environment (as the package is > built) so why do we need this patch?? I do not understand... > > Upstream builds Xpra in/for many environments be we do not as we only need to > build it for "unstable". >
I don't see any particular value in arguing about whether a failure to build from source constitutes a "severe" violation of Debian policy if we can just instead resolve the issue. Do you have a technical objection to the patch I submitted (which also improves the reproducibility of the build, another stated goal of Debian policy)? It's a very low-risk patch. If not, I can roll the patch into a MR on salsa.
