Am Donnerstag, den 07.02.2019, 08:21 -0500 schrieb Malcolm Acker: > When using pygit2 as the gitfs_provider critical errors are thrown in > the error log if the git package is not installed: > 2019-02-07 07:44:20,180 [salt.utils.gitfs :2565][ERROR ][2577] > The git command line utility is required when using the 'pygit2' > gitfs_provider. > 2019-02-07 07:44:20,181 [salt.utils.gitfs :2468][CRITICAL][2577] No > suitable gitfs provider module is installed. > 2019-02-07 07:44:20,185 [salt.loader :1702][ERROR ][2577] > Failed to load function git.envs because its module (git) is not in > the whitelist: ['gitfs', 'roots'] > > Installing the Debian git package and restarting salt-master resolves > this issue. I have briefly tested the pygit2 python module (https > clone, commit log listing) and it does not appear the python module > on it's own requires the git binary.
I checked salt/utils/gitfs.py and found out that GitProvider.clean_stale_refs() calls 'git remote prune origin'. This function is used by Pygit2._fetch(). So the git binary is still needed, unless you want to replace the 'git remote prune origin' call with a native pygit2 call. -- Benjamin Drung System Developer Debian & Ubuntu Developer 1&1 IONOS Cloud GmbH | Greifswalder Str. 207 | 10405 Berlin | Germany E-mail: benjamin.dr...@cloud.ionos.com | Web: www.ionos.de Head Office: Berlin, Germany District Court Berlin Charlottenburg, Registration number: HRB 125506 B Executive Management: Christoph Steffens, Matthias Steinberg, Achim Weiss Member of United Internet