On Sat, 2006-03-18 at 23:17 -0500, Chris Pickett wrote: > Robert Collins wrote: > > > CFLAGS="-Werror" may not have optimisations enabled in gcc -> many > > warnings are disabled. Can you reproduce with CFLAGS="-Werror -O2" ? > > I haven't tried this, but I just wanted to say: I think a lot of the > AM_PATH_CHECK macro can be cleaned up or eliminated. Probably the other > things in /usr/share/aclocal can help with that, or a "best practice" > question could be sent to the autoconf list---there might also be hints > in the autoconf manual about what to do. Clearly not every library > needs such a macro, given how few macros actually are in > /usr/share/aclocal/. ...
Sure but lets not let the perfect be the enemy of the good: There are two patches now that will correct AM_PATH_CHECK with -Werror in CFLAGS. Both are improvements, and I'm completely happy with either being applied which will fix the bug. Additionally, neither make refactoring or replacing AM_PATH_CHECK later harder - they do not change its structure or introduce additional complexity. Rob -- GPG key available at: <http://www.robertcollins.net/keys.txt>.
signature.asc
Description: This is a digitally signed message part
