On Fri, Mar 01, 2019 at 10:26:45PM -0500, Marco Villegas wrote: > I have used https://github.com/altercation/solarized repository as the > base to add the solarized color scheme to the package.
Thanks for working on this. > I am not entirely sure of the urls on metadata at > debian/vim-scripts.status, but I guess that they are OK. It is > important to notice that there is a vim.org page, i.e. > https://www.vim.org/scripts/script.php?script_id=3520, for the color > scheme, but sadly the code there contains an older version of what I > find at the repository, and that is why I decided to use the version > from the repository. > > I was a bit worried on how debian/vim-scripts.pl will handle the github > url, but both doc and update actions seems to finish OK, naturally > suggesting a false positive on the case of the new solarized addon. All of this is going to be reworked as I'm in the process of changing this package from using vim-addon-manager to dh-vim-addon. vim-addon-manager had various problems that were holding me back from updating vim-scripts. I haven't been actively working on this since it will have to wait until after Buster is released anyway. > Another detail I am not sure about is the value of disabledby at > debian/vim-scripts.status for this new addon, so I have just skipped it. For a colorscheme, it's not needed. The user has to explicitly use the colorscheme anyway. > Also, I have started by updating the html documentation for all addons, > since I could not figure out a way to only do it for the new addon. It > is in a separate commit, just in case that change is not a good idea. Agreed, that's not necessary right now. I would suggest holding off until the package gets restructured. I'll try to make some time for that again so at the very least there's an experimental branch this could be merged into. Cheers, -- James GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7 2D23 DFE6 91AE 331B A3DB
