Hi Martin,

On Sat, Mar 18, 2006 at 01:17:49PM +0000, Martin Michlmayr wrote:
> Your package fails to build with G++ 4.1.  I'm filing this bug as

Your patch was incomplete since it fixes some generated C++ code without
fixing the corresponding XSLT stylesheets which generate it.  Attached
you can find a complete patch which fixes both the stylesheets and the
generated code [1].

I'm going to upload a new version of gmetadom which includes it. Still
I've not tried the actual building with g++ 4.1 since it is not the
default compiler on my development box. If you notice any problem with
the new patch please report back.

Many thanks for the bug report and for the patch.
Cheers.

[1] If you're wondering: the double patching is needed since the debian
.orig.tar.gz ships pre-generated code to avoid extra build-dependencies,
but still we should care about users doing "make distclean" and willing
to re-generated code

-- 
Stefano Zacchiroli -*- Computer Science PhD student @ Uny Bologna, Italy
[EMAIL PROTECTED],debian.org,bononia.it} -%- http://www.bononia.it/zack/
If there's any real truth it's that the entire multidimensional infinity
of the Universe is almost certainly being run by a bunch of maniacs. -!-
#! /bin/sh /usr/share/dpatch/dpatch-run
## 11_g++41.dpatch by Stefano Zacchiroli <[EMAIL PROTECTED]>
##
## All lines beginning with `## DP:' are a description of the patch.
## DP: No description.

@DPATCH@
diff -urNad trunk~/src/gdome_cpp_smart/include/GdomeSmartDOMEventTarget.hh 
trunk/src/gdome_cpp_smart/include/GdomeSmartDOMEventTarget.hh
--- trunk~/src/gdome_cpp_smart/include/GdomeSmartDOMEventTarget.hh      
2005-07-07 05:18:49.000000000 -0400
+++ trunk/src/gdome_cpp_smart/include/GdomeSmartDOMEventTarget.hh       
2006-03-20 00:17:12.000000000 -0500
@@ -36,7 +36,7 @@
     EventTarget(const EventTarget&);
   ~EventTarget();
 
-  EventTarget::EventTarget(const class Node&);EventTarget& operator=(const 
EventTarget&);
+  EventTarget(const class Node&);EventTarget& operator=(const EventTarget&);
   bool operator==(const EventTarget& obj) const { return gdome_obj == 
obj.gdome_obj; }
   bool operator!=(const EventTarget& obj) const { return !(*this == obj); }
   
diff -urNad trunk~/src/gdome_cpp_smart/include/GdomeSmartDOMNode.hh 
trunk/src/gdome_cpp_smart/include/GdomeSmartDOMNode.hh
--- trunk~/src/gdome_cpp_smart/include/GdomeSmartDOMNode.hh     2005-07-07 
05:18:48.000000000 -0400
+++ trunk/src/gdome_cpp_smart/include/GdomeSmartDOMNode.hh      2006-03-20 
00:16:50.000000000 -0500
@@ -36,7 +36,7 @@
     Node(const Node&);
   ~Node();
 
-  Node::Node(const class EventTarget&);Node& operator=(const Node&);
+  Node(const class EventTarget&);Node& operator=(const Node&);
   bool operator==(const Node& obj) const { return gdome_obj == obj.gdome_obj; }
   bool operator!=(const Node& obj) const { return !(*this == obj); }
   
diff -urNad trunk~/src/gdome_cpp_smart/xsl/xml2hh.xsl 
trunk/src/gdome_cpp_smart/xsl/xml2hh.xsl
--- trunk~/src/gdome_cpp_smart/xsl/xml2hh.xsl   2003-09-24 03:33:06.000000000 
-0400
+++ trunk/src/gdome_cpp_smart/xsl/xml2hh.xsl    2006-03-20 00:15:53.000000000 
-0500
@@ -76,9 +76,11 @@
     <xsl:with-param name="name" select="@name"/>
   </xsl:apply-templates>  ~<xsl:value-of select="@name"/>();
 <xsl:if test="@name = 'EventTarget'">
-  EventTarget::EventTarget(const class Node&amp;);</xsl:if>
+  EventTarget(const class Node&amp;);
+</xsl:if>
 <xsl:if test="@name = 'Node'">
-  Node::Node(const class EventTarget&amp;);</xsl:if>
+  Node(const class EventTarget&amp;);
+</xsl:if>
 
   <xsl:value-of select="@name"/>&amp; operator=(const <xsl:value-of 
select="@name"/>&amp;);
   bool operator==(const <xsl:value-of select="@name"/>&amp; obj) const { 
return gdome_obj == obj.gdome_obj; }

Attachment: signature.asc
Description: Digital signature

Reply via email to