Package: blhc
Severity: normal

Hi,

I've recently activated the salsa ci infrastructure for the wsjtx
package which includes some Fortran files. The blhc check complains
about missing flags:

Running with gitlab-runner 11.7.0 (HEAD)
  on salsa-runner.debian.net f0fdd533
Using Docker executor with image 
registry.salsa.debian.org/salsa-ci-team/images/blhc ...
Pulling docker image gitlab/gitlab-runner-helper:x86_64-latest ...
Using docker image 
sha256:a775763ad0dc1e7b50b4eee51deba06d287ccb2a7f7e64765f06abb7f19b38f6 for 
gitlab/gitlab-runner-helper:x86_64-latest ...
Pulling docker image registry.salsa.debian.org/salsa-ci-team/images/blhc ...
Using docker image 
sha256:98014a729414337ec87c48b9523260e62a75d1cac79855de331a42e4552ecce8 for 
registry.salsa.debian.org/salsa-ci-team/images/blhc ...
Running on runner-f0fdd533-project-7843-concurrent-0 via 
runner-f0fdd533-1552336928-be29de41...
Skipping Git repository setup
Skipping Git checkout
Skipping Git submodules setup
Downloading artifacts for build (141711)...
Downloading artifacts from coordinator... ok        id=141711 
responseStatus=200 OK token=1MxWdCdw
$ blhc --debian --line-numbers --color ${WORKING_DIR}/*.build || [ $? -eq 1 ]
1879:CFLAGS missing (-Wformat -Werror=format-security): /usr/bin/gfortran 
-DBIGSYM=1 -DCMAKE_BUILD -DQT5 -DQT_NO_DEBUG_OUTPUT -DQT_NO_WARNING_OUTPUT 
-DUNIX -I/tmp/building/package/obj-x86_64-linux-gnu -I/tmp/building/package 
-I/tmp/building/package/obj-x86_64-linux-gnu/wsjt_fort_omp_autogen/include 
-I/usr/include  -g -O2 -fdebug-prefix-map=/tmp/building/package=. 
-fstack-protector-strong -Jfortran_modules_omp   -fopenmp -c 
/tmp/building/package/lib/packjt.f90 -o 
CMakeFiles/wsjt_fort_omp.dir/lib/packjt.f90.o
1882:CFLAGS missing (-Wformat -Werror=format-security): /usr/bin/gfortran 
-DBIGSYM=1 -DCMAKE_BUILD -DQT5 -DQT_NO_DEBUG_OUTPUT -DQT_NO_WARNING_OUTPUT 
-DUNIX -I/tmp/building/package/obj-x86_64-linux-gnu -I/tmp/building/package 
-I/tmp/building/package/obj-x86_64-linux-gnu/wsjt_fort_omp_autogen/include 
-I/usr/include  -g -O2 -fdebug-prefix-map=/tmp/building/package=. 
-fstack-protector-strong -Jfortran_modules_omp   -fopenmp -c 
/tmp/building/package/lib/77bit/packjt77.f90 -o 
CMakeFiles/wsjt_fort_omp.dir/lib/77bit/packjt77.f90.o
[...]

https://salsa.debian.org/debian-hamradio-team/wsjtx/-/jobs/141649

The -Wformat -Werror=format-security flags are not there because
dpkg-buildflags does not set them:

$ dpkg-buildflags | grep ^F
FCFLAGS=-g -O2 -fdebug-prefix-map=/home/cbe/projects/afu/wsjtx=. 
-fstack-protector-strong
FFLAGS=-g -O2 -fdebug-prefix-map=/home/cbe/projects/afu/wsjtx=. 
-fstack-protector-strong

Please don't complain about these flags.

Thanks,
Christoph

Reply via email to