* Paul Gevers: " Fwd: Bug#923282: freezegun breaks cached-property
  autopkgtest" (Tue, 12 Mar 2019 21:51:28 +0100):

Hi all,

> [<mbeh...@debian.org> bounced, trying again.
> 
> -------- Forwarded Message --------
> Subject: Re: Bug#923282: freezegun breaks cached-property autopkgtest
> Date: Tue, 5 Mar 2019 19:35:35 +0100
> From: Paul Gevers <elb...@debian.org>
> To: 923...@bugs.debian.org, Mathias Behrle <mbeh...@debian.org>, Dominik
> George <naturesha...@debian.org>
> 
> Hi all,
> 
> On Wed, 27 Feb 2019 00:38:16 +0100 Mathias Behrle <mbeh...@debian.org>
> wrote:> I don't see how
> > anything could be done from the side of cached_property at this stage of the
> > freeze. Therefore I am bumping the bug to severity serious to be safe this
> > version of freezegun will not migrate to testing and assigning to
> > freezegun.  
> 
> Keeping this version of freezegun out of buster for this is trading one
> RC bug versus another.
> 
> Mathias, could you please check if you can make cached_property
> compatible with the current freezegun in unstable, as that means we
> could move things forward.

My research shows that the issue is known for cached_property since 5 Nov 2018
[1], related issues for freezegun date from 21 Oct 2018 [2] resp. 17 Oct 2018
[3]. Indeed freezegun obviously introduced substantial API changes from 0.3.10
to 0.3.11 (btw in no way following semver).

What can be done in the current situation:

1) I really don't see what can be done on the side of cached_property. No
solution so far was able to workaround the test failures acording to [1]. If
there is any input from the freezegun maintainers how the tests could be
changed to pass I am all open for it.

2) freezegun 0.3.11 was released on 15 Oct 2018 [4] and there seem to be some
more recent commits related to this issue (e.g. [5]). I would propose to
cherry-pick some relevant commits or to package current trunk from git to see
if it solves the issues.

3) As a last resort the release team should be involved to evtl. mark the issue
as ignore for buster.

4) If that should be impossible/not desired I would be willing as a very very
last resort to disable temporarily the relevant autopkgtests in cached_property.
Basically cached_property *is* and *was* working, it is only that the tests are
failing due to API incompatibilities introduced by a test utility (freezegun)
during or shortly before the soft freeze. 


> Dominik, did you investigate if a different solution for the FTBFS of
> freezegun in bug 916702 [1] was possible?
> 
> Federico, I would appreciate it when you would share your opinion on how
> to solve the freezegun situation for buster.
> 
> Time is ticking.

My personal preference obviously goes to 1) or 2). Please advise on how to
proceed further.

Mathias

[1] https://github.com/pydanny/cached-property/issues/131
[2] https://github.com/ktosiek/pytest-freezegun/issues/6
[3] https://github.com/spulec/freezegun/issues/269
[4] https://pypi.org/project/freezegun/#history
[5]
https://github.com/spulec/freezegun/commit/028dee229f06d200d0f79a130deaad65b14779ef


-- 

    Mathias Behrle ✧ Debian Developer
    PGP/GnuPG key availabable from any keyserver, ID: 0xD6D09BE48405BBF6
    AC29 7E5C 46B9 D0B6 1C71  7681 D6D0 9BE4 8405 BBF6

Reply via email to