Control: tag -1 + upstream fixed-upstream

On Wed, Mar 27, 2019 at 07:47:15PM +0000, Matthias Klose wrote:
> From test_mksession.vim:
> Found errors in Test_mksession_arglist():
> Caught exception in Test_mksession_arglist(): Vim(set):E539: Illegal 
> character <a>: shortmess=aoO @ 
> /<<PKGBUILDDIR>>/src/nvim/testdir/Xtest_mks.out, line 8
> Found errors in Test_mksession_winheight():
> Caught exception in Test_mksession_winheight(): Vim(set):E539: Illegal 
> character <a>: shortmess=aoO @ 
> /<<PKGBUILDDIR>>/src/nvim/testdir/Xtest_mks.out, line 8

This ended up being due to the new compound literal lifetime changes --
https://gcc.gnu.org/gcc-9/porting_to.html#complit.

The code in question is something close to:

  unsigned char *varp;
  unsigned char *p;

  if (varp == &p_shm) {
    p = (unsigned char *)((unsigned char[]){ 'a', 'b', 'c' });
  }
  ...

  // iterate over p

It would have been helpful in diagnosing this if gcc had warned about
using a pointer to an object outside of its scope.

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB

Attachment: signature.asc
Description: PGP signature

Reply via email to