Hi,
On 4/14/19 3:04 PM, Adam Borowski wrote:
> On Sun, Apr 14, 2019 at 10:25:55AM +0200, Birger Schacht wrote:
>>
>> * Package name : errbot
>> Version : 6.0+ds-1
>
>> It builds those binary packages:
>>
>> * errbot
>
> Hi!
> In the .service file, you use LC_ALL=en_US.UTF-8 unconditionally. That
> won't work for anyone who's doesn't have that locale generated. Besides
> USians, many people whose native language is not English use that as
> fallback (it's d-i's default in such cases), but Brits, Aussies and the like
> will have en_{UK,AU}.UTF-8 instead. The only guaranteed locale is C.UTF-8.
> Very likely that'd be enough for you -- but if not, you'd need to organize
> a way to run the daemon with a privately generated locale.
Hm, I've copied that from upstreams service file example, but it also
works if I don't set LC_ALL at all, so I've removed the line.
> Also, why .service instead of an init script? This makes the daemon work
> only with systemd -- not with sysv-rc, openrc, runit, etc. In particular,
> this means that _I_ can't (without extra effort) test this package.
> Of the following combinations:
> * .service, no init
> * both .service and init
> * init, no .service
> the latter two work everywhere; the last one being least work.
The system service file uses the DynamicUser feature of systemd, which
means the package does not have to create an account for the daemon. But
I've now added an init script, a default file to override the path to
the config file and added a postinst file to add the account and the
needed files for the service.
cheers,
Birger
>
> Everything else about the package seems to be ok.
>
>
> Meow!
>
