On 2019-05-03 22:49:29, tho...@fiasko-nw.net wrote:
> tags 927963 upstream
> thanks
>
>
> Hi Antoine,
>
>
> On Thu, 25 Apr 2019, Antoine Beaupre wrote:
>
>> And here's DSA's check libs:
>>
>> # dsa-check-libs --verbose
>> Running /usr/bin/lsof -F0 -n
>> adding dhclient(976) because of
>> [/lib/x86_64-linux-gnu/libisc-export.so.1100.0.0]:
>> fDELa l tREGD0xfe00i917519n/lib/x86_64-linux-gnu/libisc-export.so.1100.0.0
>> adding dhclient(976) because of
>> [/lib/x86_64-linux-gnu/libdns-export.so.1104.0.2]:
>> fDELa l tREGD0xfe00i917788n/lib/x86_64-linux-gnu/libdns-export.so.1104.0.2
>> The following processes have libs linked that were upgraded: root: dhclient
>> (976)
>
> this is(|was) intentional. The default config of needrestarts blacklists
> well known DHCP clients due to #752111.
>
>
>> ... so I believe the program should be marked as needing
>
> If you remove it from the blacklist it should suggest to restart
> ifup@eth0.service.
>
>
>> restart. Naturally, it might not be safe to do so, but it should at
>> least warn. The program is part of the ifup@eth0.service:
>>
>> CGroup: /system.slice/ifup@eth0.service
>> └─976 /sbin/dhclient -4 -v -i -pf /run/dhclient.eth0.pid -lf
>> /var/lib/dhcp/dhclient.eth0.leases -I -df
>> /var/lib/dhcp/dhclient6.eth0.leases eth0
>>
>> In my tests, "systemctl restart ifup@eth0.service" safely returned,
>> when running under "screen".
>
> IMHO on systemd there is no need for screen. For systemd + dhclient it
> should be save to remove the blacklist entry. I'm not sure how the
> situation is under NetworkManager or WICD.
In my opinion, a "blacklisted" service should still warn. Isn't that the
case for stuff like dbus that they do get marked as needing a restart
but don't get restarted automatically?
A.
--
O gentilshommes, la vie est courte.
Si nous vivons, nous vivons
pour marcher sur la tête des rois.
- William Shakespeare
