Package: rmlint-gui
Version: 2.8.0-3
Severity: normal
Tags: patch
Dear Maintainer,
In an attempt to only delete duplicates fo non-empty files, I set a lower size
limit on the duplicate file size of a few bytes, in the Settings view of the
gui, but shredder kept reporting them.
Clicking on the 'Generate script' button I saw in the script that the rmlint
command line that run by shredder contained the option:
"--size 0M-17179869184M"
This was observed to happen with lower limit up to 999 kb, and causes files
smaller than the set limit to be listed anyways and worse, if the upper limit
is also lower than 1 Mb, then only empty files are listed.
The observed result is that any file size limit lower than 1 Mb (both lower and
upper) is forced to 0 Mb before it is passed to the command line scanner with
incorrect value.
The expected result is that file size limits are passed correctly to the
command line scanner and no manual selection is needed to exclude unwanted
matches from deletion.
The issue can be tracked down to lines 177--181 of file
'/usr/lib/python3/dist-packages/shredder/runner.py'
====================%<----------------------
extra_options += [
'--size', '{a}M-{b}M'.format(
a=min_size // (1024 ** 2),
b=max_size // (1024 ** 2)
)
====================%<----------------------
where all file size limits are converted to Mb, truncating to an integer.
The issue has already been reported and fixed upstream:
https://github.com/sahib/rmlint/commit/5a5cf895df405ae4eb3d4d9dd87d5c76de66dbbc
Please incorporate the fix at your leisure.
PS. I am not certain that adding the patch tag because I provide a link to the
commit that fixes
the bug upstream is the correct thing to do, do in case it is not,
remove it.
Best regards,
Diego
-- System Information:
Debian Release: buster/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: amd64 (x86_64)
Kernel: Linux 4.19.0-4-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=it_IT.UTF-8, LC_CTYPE=it_IT.UTF-8 (charmap=UTF-8),
LANGUAGE=it_IT:it (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages rmlint-gui depends on:
ii dconf-gsettings-backend [gsettings-backend] 0.30.1-2
ii gir1.2-gtksource-3.0 3.24.9-2
ii gir1.2-polkit-1.0 0.105-25
ii gir1.2-rsvg-2.0 2.44.10-2.1
ii python3 3.7.2-1
ii python3-cairo 1.16.2-1+b1
ii python3-gi 3.30.4-1
ii rmlint 2.8.0-3
Versions of packages rmlint-gui recommends:
ii python3-colorlog 4.0.1-1
rmlint-gui suggests no packages.
-- no debconf information
