Package: openbabel
Version: 2.0.0-1
Severity: important
Tags: patch
Your package fails to build with G++ 4.1. I'm filing this bug as
important for now, but when 4.1 will be the default compiler in
unstable (probably in a few weeks) I'll upgrade this to serious.
A patch is attached.
P.S. G++ and you don't stop (to fix bugs!)
> Automatic build of openbabel_2.0.0-1 on bigsur by sbuild/mips 1.106
...
> g++ -DHAVE_CONFIG_H -I. -I. -I../../../src -I../../../src -I../../../data
> -I/usr/include/libxml2 -g -Wall -O2 -MT cmlreactlformat.lo -MD -MP -MF
> .deps/cmlreactlformat.Tpo -c cmlreactlformat.cpp -fPIC -DPIC -o
> .libs/cmlreactlformat.o
> xml.h:44: error: extra qualification 'OpenBabel::XMLConversion::' on member
> 'SetupReader'
> xml.h:45: error: extra qualification 'OpenBabel::XMLConversion::' on member
> 'SetupWriter'
> xml.h:61: error: extra qualification 'OpenBabel::XMLConversion::' on member
> 'RegisterXMLFormat'
> xml.h:68: error: extra qualification 'OpenBabel::XMLConversion::' on member
> 'IsLast'
> xml.h:70: error: extra qualification 'OpenBabel::XMLConversion::' on member
> 'GetOutputIndex'
> xml.h:99: error: extra qualification 'OpenBabel::XMLConversion::' on member
> 'GetContent'
> xml.h: In member function 'void OpenBabel::XMLConversion::OutputToStream()':
> xml.h:82: warning: unused variable 'ret'
> cmlreactlformat.cpp: At global scope:
> cmlreactlformat.cpp:54: error: extra qualification
> 'OpenBabel::CMLReactFormat::' on member 'Flags'
> make[5]: *** [cmlreactlformat.lo] Error 1
> make[5]: Leaving directory `/build/tbm/openbabel-2.0.0/src/formats/xml'
--- ./src/formats/xml/xml.h~ 2006-03-23 12:07:03.000000000 +0000
+++ ./src/formats/xml/xml.h 2006-03-23 12:07:28.000000000 +0000
@@ -41,8 +41,8 @@
///Frees reader and writer if necessary
~XMLConversion();
- bool XMLConversion::SetupReader();///< opens libxml2 reader
- bool XMLConversion::SetupWriter();///< opens libxml2 writer
+ bool SetupReader();///< opens libxml2 reader
+ bool SetupWriter();///< opens libxml2 writer
///Parses the input xml stream and sends each element to the format's
callback routines
bool ReadXML(XMLBaseFormat* pFormat, OBBase* pOb);
@@ -57,7 +57,7 @@
return *nsm;
};
- static void XMLConversion::RegisterXMLFormat(XMLBaseFormat* pFormat,
+ static void RegisterXMLFormat(XMLBaseFormat* pFormat,
bool IsDefault=false, const char* uri=NULL);
///Returns the extended OBConversion class, making it if necessary
@@ -65,9 +65,9 @@
///Because OBConversion::Convert is still using the unextended
OBConversion object
///we need to obtain the conversion paramters from it when requested
- bool XMLConversion::IsLast()
+ bool IsLast()
{ return _pConv->IsLast(); }
- int XMLConversion::GetOutputIndex()
+ int GetOutputIndex()
{ return _pConv->GetOutputIndex(); }
@@ -96,7 +96,7 @@
string GetAttribute(const char* attrname);
///Sets value to element content. Returns false if there is no content.
- string XMLConversion::GetContent();
+ string GetContent();
///Sets value to element content as an integer. Returns false if there
is no content.
bool GetContentInt(int& value);
--- ./src/formats/xml/cmlreactlformat.cpp~ 2006-03-23 12:07:38.000000000
+0000
+++ ./src/formats/xml/cmlreactlformat.cpp 2006-03-23 12:07:45.000000000
+0000
@@ -51,7 +51,7 @@
\n";
}
- unsigned CMLReactFormat::Flags()
+ unsigned Flags()
{
return 0;
}
--- ./src/formats/xml/xmlformat.cpp~ 2006-03-23 12:09:09.000000000 +0000
+++ ./src/formats/xml/xmlformat.cpp 2006-03-23 12:09:20.000000000 +0000
@@ -21,12 +21,12 @@
class XMLFormat : XMLBaseFormat
{
public:
- XMLFormat::XMLFormat()
+ XMLFormat()
{
OBConversion::RegisterFormat("xml",this);
}
- const char* XMLFormat::Description()
+ const char* Description()
{
return " \
General XML format\n \
@@ -40,7 +40,7 @@
const char* NamespaceURI()const{return "Undefined";};
- unsigned XMLFormat::Flags()
+ unsigned Flags()
{
return NOTWRITABLE;
}
--- ./src/formats/copyformat.cpp~ 2006-03-23 12:09:52.000000000 +0000
+++ ./src/formats/copyformat.cpp 2006-03-23 12:09:58.000000000 +0000
@@ -41,7 +41,7 @@
};
/////////////////////////////////////////////////////////////////
- virtual bool CopyFormat::WriteChemObject(OBConversion* pConv)
+ virtual bool WriteChemObject(OBConversion* pConv)
{
pConv->GetChemObject();//needed to increment pConv->Index
--- ./src/formats/crkformat.cpp~ 2006-03-23 12:10:29.000000000 +0000
+++ ./src/formats/crkformat.cpp 2006-03-23 12:10:34.000000000 +0000
@@ -61,8 +61,8 @@
virtual bool ReadMolecule(OBBase* pOb, OBConversion* pConv);
virtual bool WriteMolecule(OBBase* pOb, OBConversion* pConv);
- static bool CRK2DFormat::ReadCRK(std::istream &ifs,OBMol &mol,const char
*classTag);
- static void CRK2DFormat::WriteCRK(std::ostream &ofs,OBMol &mol,bool
GroupCharges);
+ static bool ReadCRK(std::istream &ifs,OBMol &mol,const char *classTag);
+ static void WriteCRK(std::ostream &ofs,OBMol &mol,bool GroupCharges);
};
--- ./src/fingerprint.h~ 2006-03-23 12:11:37.000000000 +0000
+++ ./src/fingerprint.h 2006-03-23 12:11:43.000000000 +0000
@@ -60,7 +60,7 @@
static double Tanimoto(const std::vector<unsigned int>& vec1, const
std::vector<unsigned int>& vec2);
/// Inline version of Tanimoto() taking a pointer for the second vector
- static double OBFingerprint::Tanimoto(const std::vector<unsigned int>&
vec1, const unsigned int* p2)
+ static double Tanimoto(const std::vector<unsigned int>& vec1, const
unsigned int* p2)
{
///If used for two vectors, vec1 and vec2, call as
Tanimoto(vec1, &vec2[0]);
int andbits=0, orbits=0;
--
Martin Michlmayr
http://www.cyrius.com/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
