Control: tag -1 + pending

Hello Helmut,

On 6/21/19 3:59 PM, Helmut Grohne wrote:
> On Fri, Jun 21, 2019 at 02:55:53PM +0200, Uwe Kleine-König wrote:
>> On 6/21/19 1:36 PM, Nguyen Hoang Tung wrote:
>>> rt-tests fails to cross build because its dependency, libnuma-dev:armhf,
>>> is missing.Using armhf architecture of the dependency can solve this
>>> problem.
>>
>> I'm pretty sure your patch is wrong. Goes your problem away if you
>> replace DEB_BUILD_ARCH by DEB_TARGET_ARCH in debian/rules?
> 
> What Nguyen Hoang Tung writes is mostly correct. The cross build fails
> for armhf.  Adding the dependency probably makes it succeed.
> 
> http://crossqa.debian.net/src/rt-tests quite nicely shows the pattern.
> The mipsen have the libnuma-dev dependency and they do cross.
> 
> However that's not the intended solution. Clearly, someone intended
> rt-tests to be built without numa support for armhf. Matching on
> DEB_BUILD_ARCH is as wrong as DEB_TARGET_ARCH. The terms "build", "host"
> and "target" are explained in man dpkg-architecture.

Thanks for chiming in here. I changed it to DEB_HOST_ARCH now.

> Also debian/rules is inconsistent with debian/control. Someone should
> fix that up. e.g. ppc64 and x32 differ.

I admit it's ugly, but without consequences as NUMA defaults to 1 in the
cases that were not explicitly mentioned. Fixed en passant.

See
https://git.pengutronix.de/cgit/ukl/rt-tests/commit/?id=8f976d1680dd3bbdc434b1a8eab56226f5b66022

Best regards and thanks for your time,
Uwe

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to