Bug#565436: closed by Mattia Rizzolo (Re: Bug#565436: pbuilder: new $HOME value broke my hook scripts)

[Francesco Poli]

On Sun, 7 Jul 2019 21:13:28 +0000 (UTC) Thorsten Glaser wrote:

> Francesco Poli dixit:
> 
> >Please add this harmless line to /usr/lib/pbuilder/pdebuild-internal:
> >
> >  export DEBSOURCEDIR=$(readlink -f $(pwd))
> 
> Harmful. You’ll want:
> 
>     DEBSOURCEDIR=$(readlink -f "$(pwd)"); export DEBSOURCEDIR

Why harmful?
Because it is a bashism?
I agree that it is a bashism, but:

  $ head -n 1 /usr/lib/pbuilder/pdebuild-internal
  #! /bin/bash

hence, it should be OK anyway.
Please note that there already is a:

  export HOME=$(readlink -f $(pwd)/../)
  if [ -z "${HOME}" ]; then
      echo "E: Failed to obtain reasonable HOME from pwd"
  fi


Or am I misunderstanding your comment?



-- 
 http://www.inventati.org/frx/
 There's not a second to spare! To the laboratory!
..................................................... Francesco Poli .
 GnuPG key fpr == CA01 1147 9CD2 EFDF FB82  3925 3E1C 27E1 1F69 BFFE

pgpiTlmCk8PJE.pgp
Description: PGP signature