Package: ktorrent
Version: 5.1.1-1+b1
Severity: normal
Tags: patch

--- Please enter the report below this line. ---

Bug is known in upstream https://bugs.kde.org/show_bug.cgi?id=368114 since 
2017(!!!), even the patch is available. How TF it still didn't get in 5.1.1 is 
beyond my understanding.

--- System information. ---
Architecture: 
Kernel:       Linux 4.19.37-bootes0-iommu-p-1000

Debian Release: 10.0
  991 stable          security.debian.org 
  991 stable          ftp.fi.debian.org 
   99 stable          www.deb-multimedia.org 
  500 stable          dl.google.com 
  500 stable          deb.torproject.org 

--- Package information. ---
Depends                                            (Version) | Installed
============================================================-+-
==================================
kio                                                          | 5.54.1-1
libc6                                              (>= 2.14) | 
libgcc1                                           (>= 1:3.0) | 
libgeoip1                                                    | 
libkf5archive5                                   (>= 4.96.0) | 
libkf5completion5                                (>= 4.97.0) | 
libkf5configcore5                                (>= 4.98.0) | 
libkf5configgui5                                 (>= 4.97.0) | 
libkf5configwidgets5                             (>= 4.96.0) | 
libkf5coreaddons5                                (>= 5.16.0) | 
libkf5crash5                                     (>= 5.15.0) | 
libkf5dbusaddons5                                (>= 4.99.0) | 
libkf5dnssd5                                     (>= 4.96.0) | 
libkf5i18n5                                      (>= 4.97.0) | 
libkf5iconthemes5                                (>= 4.96.0) | 
libkf5itemviews5                                 (>= 4.96.0) | 
libkf5kcmutils5                                  (>= 4.96.0) | 
libkf5kiocore5                                   (>= 4.96.0) | 
libkf5kiofilewidgets5                            (>= 4.96.0) | 
libkf5kiowidgets5                                (>= 4.96.0) | 
libkf5krosscore5                                 (>= 4.96.0) | 
libkf5notifications5                             (>= 4.96.0) | 
libkf5notifyconfig5                              (>= 4.96.0) | 
libkf5parts5                                     (>= 4.96.0) | 
libkf5plotting5                                  (>= 4.96.0) | 
libkf5service-bin                                            | 
libkf5service5             (>= 5.4.0+git20141113.1055+15.04) | 
libkf5syndication5abi1                         (>= 18.07.90) | 
libkf5textwidgets5                                (>= 5.0.0) | 
libkf5torrent6                                      (>= 2.1) | 
libkf5webkit5                                    (>= 4.96.0) | 
libkf5widgetsaddons5                             (>= 4.96.0) | 
libkf5windowsystem5                              (>= 4.96.0) | 
libkf5xmlgui5                                    (>= 4.98.0) | 
libphonon4qt5-4                                 (>= 4:4.8.0) | 
libqt5core5a                                 (>= 5.11.0~rc1) | 
libqt5dbus5                                       (>= 5.7.0) | 
libqt5gui5                                        (>= 5.8.0) | 
libqt5network5                                    (>= 5.7.0) | 
libqt5webkit5                                  (>= 5.6.0~rc) | 
libqt5widgets5                               (>= 5.11.0~rc1) | 
libqt5xml5                                        (>= 5.7.0) | 
libstdc++6                                          (>= 5.2) | 
libtag1v5                                    (>= 1.9.1-2.2~) | 
phonon4qt5                                                   | 
ktorrent-data                                    (= 5.1.1-1) | 
libktorrent-l10n                                             | 


Package's Recommends field is empty.

Suggests            (Version) | Installed
=============================-+-===========
krosspython                   | 4:18.08.1-1
geoip-database                | 20181108-1




>From af1abedb3bc5cd8e73f134e123857b0f9dcaa239 Mon Sep 17 00:00:00 2001
From: Valeriy Malov <jazzv...@gmail.com>
Date: Tue, 24 Oct 2017 00:54:30 +0300
Subject: Disable logging to stdout by default

Summary:
Do not log to stdout by default since ktorrent logs are very verbose and
pollute session log (e.g. xsession-errors), while ktorrent manages it's
own log files in ~/.local/share/ktorrent.

Add command line option to enable logging to stadnard output again, if
needed.

Remove some duplicate headers.

BUG: 368114

Reviewers: stikonas

Subscribers: ltoscano

Differential Revision: https://phabricator.kde.org/D8438
---
 ktorrent/main.cpp | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ktorrent/main.cpp b/ktorrent/main.cpp
index 24f1cc8..19693b7 100644
--- a/ktorrent/main.cpp
+++ b/ktorrent/main.cpp
@@ -43,11 +43,7 @@
 #include <KStartupInfo>
 #include <KWindowSystem>
 
-#include <util/log.h>
 #include <torrent/globals.h>
-#include <util/functions.h>
-#include <util/error.h>
-#include <util/log.h>
 #include <interfaces/functions.h>
 #include <utp/connection.h>
 #include "gui.h"
@@ -179,6 +175,7 @@ int main(int argc, char** argv)
 
     KAboutData::setApplicationData(about);
     about.setupCommandLine(&parser);
+    parser.addOption(QCommandLineOption(QStringList() << QStringLiteral("verbose"), i18n("Enable logging to standard output")));
     parser.addOption(QCommandLineOption(QStringList() <<  QStringLiteral("silent"), i18n( "Silently open torrent given on URL")));
     parser.addOption(QCommandLineOption(QStringList() <<  QStringLiteral("+[URL]"), i18n( "Document to open" )));
     parser.process(app);
@@ -205,7 +202,8 @@ int main(int argc, char** argv)
         QObject::connect(&catcher, &bt::SignalCatcher::triggered, &app, &QApplication::quit);
 #endif
 
-        bt::InitLog(kt::DataDir(kt::CreateIfNotExists) + QLatin1String("log"), true, true, true);
+        const bool logToStdout = parser.isSet(QStringLiteral("verbose"));
+        bt::InitLog(kt::DataDir(kt::CreateIfNotExists) + QLatin1String("log"), true, true, logToStdout);
 
         kt::GUI widget;
         widget.show();
-- 
cgit v1.1

Reply via email to