Matthew Vernon writes ("Bug#932322: dgit: Add support for Ubuntu cloud
archive"):
> It would be nice to be able to dgit clone packages from the Ubuntu
> Cloud Archive (see https://wiki.ubuntu.com/OpenStack/CloudArchive ). I
> wrote the attached patch to do this.
Thanks for this and well done for getting this working.
However, I think this patch needs a bit more work :-/.
I wrote on IRC:
23:27 <Diziet> Woah, not sure relaxing suite_re is safe
23:29 <Diziet> Is / allowed in git config variable names ? I think so, cf
insteadOf
^ the above was prompted by the fact that dgit constructs git config
setting names from suite names
23:32 <Diziet> Did you do any kind of audit to check that relaxing that re was
OK ? In the general case such an audit is necessary and it
would be actually helpful to have two people do it...
23:32 <Diziet> Can you split that change out into its own commit and provide
not just an explanation of why it's needed but also why you
think it is OK ?
23:32 <Diziet> There's a suite map thing (see the debian-security config) which
could be used to get rid of the /
In the meantime I will see if I can do my own audit to see whether /
is OK. Please let me know the list of necessary changes. A cursory
glance has found one place already where / would cause trouble; it
needs a code change but it would not affect your use case.
--
Ian Jackson <[email protected]> These opinions are my own.
If I emailed you from an address @fyvzl.net or @evade.org.uk, that is
a private address which bypasses my fierce spamfilter.
