control: clone 932199 -2
control: reassing -2 initscripts
control: retitle -2 move /etc/init.d/mountnfs.sh to bin:nfs-common
control: severity -2 wishlist
control: forcemerge 932199 932266
control: tags 932199 +patch
[2019-07-16 16:30] Thorsten Glaser <t...@mirbsd.de>
> Upgrading my system:
>
> […]
> Preparing to unpack .../107-insserv_1.20.0-1_x32.deb ...
> Unpacking insserv (1.20.0-1) over (1.14.0-5.4) ...
> […]
> etting up inetutils-syslogd (2:1.9.4-8) ...
> Installing new version of config file /etc/init.d/inetutils-syslogd ...
> insserv: warning: could not find all dependencies for $portmap
> insserv: warning: could not find all dependencies for $portmap
> Restarting system log daemon syslogd.
> Stopping system log daemon: syslogd.
> Starting system log daemon: syslogd.
> Setting up libgnutls30:i386 (3.6.8-2) ...
> […]
>
> And, indeed, I do not have portmap installed.
>
> tglase@tglase:~ $ sudo fgrep -r \$portmap /etc/init.d/
> /etc/init.d/umountnfs.sh:# Should-Stop: $network $portmap nfs-common
> /etc/init.d/mountnfs.sh:# Should-Start: $network $portmap nfs-common
> udev-mtab
> /etc/init.d/README:# Should-Start: $portmap
> /etc/init.d/README:# Should-Stop: $portmap
Okay. I managed to reproduce this bug. It is triggered by unknown
virtual facility. Facility is unknown if it is mentioned neither in
/etc/insserv.conf nor in /etc/insserv.conf.d.
On my system, $x-display-manager is defined in /etc/insserv.conf.d/xdm;
on headless box there is no display manager, hence warning. Situation
with $portmap seems similar.
By the way, lightdm seems (according to apt-file) to not provide
/etc/insserv.conf.d/lightdm file. This is bug, I think.
This warning was introduced in upstream [ddd9d38] with following
changelog:
- When an initscript contains a "$service" dependency which cannot be
resolved (ie $service does not expand or does not exist) insserv
will display a warning. The initscript is still added.
Seems problem is that warning emitted not only for hard, but only for
soft dependencies. Patch at bottom.
Please check whether is solves all problems.
> /etc/init.d/mountnfs.sh is from initscripts (= 2.93-8). Perhaps it
> ought to be moved to nfs-common or so? That being said, nfs-common
> does not Depends on portmap either…
Sounds reasonable. Created bug.
From 233d6578855def060f9fe9d1fb62918911a209b8 Mon Sep 17 00:00:00 2001
From: Dmitry Bogatov <kact...@debian.org>
Date: Wed, 17 Jul 2019 18:50:53 +0000
Subject: [PATCH] Fix spurious warnings about unknown virtual dependencies
Closes: #932199
---
...nings-about-unknown-virtual-dependen.patch | 26 +++++++++++++++++++
debian/patches/series | 1 +
2 files changed, 27 insertions(+)
create mode 100644
debian/patches/0004-Fix-spurious-warnings-about-unknown-virtual-dependen.patch
diff --git
a/debian/patches/0004-Fix-spurious-warnings-about-unknown-virtual-dependen.patch
b/debian/patches/0004-Fix-spurious-warnings-about-unknown-virtual-dependen.patch
new file mode 100644
index 0000000..c69214d
--- /dev/null
+++
b/debian/patches/0004-Fix-spurious-warnings-about-unknown-virtual-dependen.patch
@@ -0,0 +1,26 @@
+From: Dmitry Bogatov <kact...@debian.org>
+Date: Wed, 17 Jul 2019 18:45:45 +0000
+Subject: Fix spurious warnings about unknown virtual dependencies
+
+Do not emit warnings about unknown virtual($foo) facility soft
+dependency. It is perfectly fine to have soft (should) dependency
+on facility, provided by currently not installed package.
+
+Closes: #932199
+---
+ insserv.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/insserv.c b/insserv.c
+index 90ea1bd..0c638dd 100644
+--- a/insserv.c
++++ b/insserv.c
+@@ -471,7 +471,7 @@ static void rememberreq(service_t * restrict serv, uint
bit, const char * restri
+ break;
+ }
+ }
+- if (! can_expand_name)
++ if (! can_expand_name && (bit & REQ_MUST))
+ warn("warning: could not find all dependencies for %s\n",
token);
+
+ break;
diff --git a/debian/patches/series b/debian/patches/series
index 27b8394..cbda0c6 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -1,3 +1,4 @@
11_debian_conf.patch
110_portmap.patch
warn_in_ignore_mode.patch
+0004-Fix-spurious-warnings-about-unknown-virtual-dependen.patch
--
Note, that I send and fetch email in batch, once in a few days.
Please, mention in body of your reply when you add or remove recepients.
