Source: libminini
Version 1.2.a+ds-2
Severity: serious
tags: patch
Hello, I discovered libminini stopped using cmake and switched to plain
Makefiles...
but is not installing anymore the required headers
diff -Nru libminini-1.2.a+ds/debian/patches/Makefile.patch
libminini-1.2.a+ds/debian/patches/Makefile.patch
--- libminini-1.2.a+ds/debian/patches/Makefile.patch 2019-07-29
05:32:00.000000000 +0200
+++ libminini-1.2.a+ds/debian/patches/Makefile.patch 2019-07-30
21:54:11.000000000 +0200
@@ -12,7 +12,7 @@
+
+CPPFLAGS += -fPIC
+
-+HEADERS := minIni.h
++HEADERS := *.h
+SRCS := minIni.cc
+OBJS := $(SRCS:.cc=.o)
+
this makes utox FTBFS in sid...
btw what is the rationale behind dropping the cmake file? I can help fixing it
if needed... not sure why you dropped it!
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/messages.c.o -c /<<PKGBUILDDIR>>/src/messages.c
[ 82%] Building C object CMakeFiles/utox.dir/src/notify.c.o
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/notify.c.o -c /<<PKGBUILDDIR>>/src/notify.c
[ 83%] Building C object CMakeFiles/utox.dir/src/qr.c.o
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/qr.c.o -c /<<PKGBUILDDIR>>/src/qr.c
/<<PKGBUILDDIR>>/src/messages.c: In function ???messages_draw_filetransfer???:
/<<PKGBUILDDIR>>/src/messages.c:907:47: warning: format ???%lu??? expects
argument of type ???long unsigned int???, but argument 4 has type
???uint64_t??? {aka ???long long unsigned int???} [-Wformat=]
907 | p += snprintf(p, speed - p, "/s %lus",
| ~~^
| |
| long unsigned int
| %llu
908 | file->speed ? (file->size -
file->progress) / file->speed : 0);
|
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
uint64_t {aka long long unsigned int}
[ 85%] Building C object CMakeFiles/utox.dir/src/screen_grab.c.o
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/screen_grab.c.o -c /<<PKGBUILDDIR>>/src/screen_grab.c
[ 86%] Building C object CMakeFiles/utox.dir/src/self.c.o
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/self.c.o -c /<<PKGBUILDDIR>>/src/self.c
[ 87%] Building C object CMakeFiles/utox.dir/src/settings.c.o
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/settings.c.o -c /<<PKGBUILDDIR>>/src/settings.c
[ 88%] Building C object CMakeFiles/utox.dir/src/text.c.o
/usr/bin/cc -isystem /usr/include/minIni -isystem /usr/include/qrcodegen -g
-O2 -fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -g -O2
-fdebug-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -Wformat
-Werror=format-security -Wdate-time -D_FORTIFY_SOURCE=2 -Wall -Wextra
-Wpointer-arith -Wimplicit-fallthrough=5 -Werror=implicit-function-declaration
-Wno-misleading-indentation -fno-strict-aliasing -fPIC -flto -std=gnu11 -o
CMakeFiles/utox.dir/src/text.c.o -c /<<PKGBUILDDIR>>/src/text.c
In file included from /<<PKGBUILDDIR>>/src/settings.c:23:
/usr/include/minIni/minIni.h:22:10: fatal error: minGlue.h: No such file or
directory
22 | #include "minGlue.h"
| ^~~~~~~~~~~
compilation terminated.
make[3]: *** [CMakeFiles/utox.dir/build.make:313:
CMakeFiles/utox.dir/src/settings.c.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-i686-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:80: CMakeFiles/utox.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-i686-linux-gnu'
make[1]: *** [Makefile:166: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-i686-linux-gnu'
dh_auto_build: cd obj-i686-linux-gnu && make -j4 "INSTALL=install
--strip-program=true" returned exit code 2
make: *** [debian/rules:12: build-arch] Error 255
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit
status 2
