On Sun, 2019-07-28 at 22:14 +0200, Matthieu CERDA wrote: > Package: qcontrol > Version: 0.5.6-4~bpo9+1 > Severity: important > Tags: patch > > Hello maintainer!
Hi Matthieu, thank you for the report. > There seems to be a small typo, related to > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=781886, > in the qcontrold systemd unit. > > The unit depends on: > /dev/input/by-path/platform-gpio_keys-event > > The actual file to watch for seems to be: > /dev/input/by-path/platform-gpio-keys-event Unfortunately this is kernel version dependent. At least on 4.9.168- 1+deb9u3 it is still /dev/input/by-path/platform-gpio_keys-event. My recollection is that it previously changed from - to _ around the Jessie time frame. It seems like perhaps it has changed back again some time before the 4.19.0-0.bpo.5-marvell you are running, which is most inconvenient. I'll need to dig in and see how/when/where this has changed again. Hopefully it's not platform specific, which platform are you on? The /etc/qcontrol.conf files cope with either name, but I don't know how (not sure it is possible) to do the same in a systemd unit. Unfortunately I don't run systemd on an of my qnap systems and I've recently moved countries leaving my spare/test system in the loft back in the UK. So any help with the systemd side of things would be appreciated. In case it isn't possible to support both then I think I'd want to have qcontrol using the same path as the kernel in the corresponding release, meaning users of bpo would be responsible for tweaking things if they didn't get both packages from the same release (you seem to have both kernel and qcontrol from bpo, so that's fine, or should be if it weren't for this bug). Ian. > > Here's a patch: > ---8<--- > --- a/lib/systemd/system/qcontrold.service 2018-05-27 > 12:00:11.000000000 +0200 > +++ b/etc/systemd/system/qcontrold.service 2019-07-28 > 21:22:34.048521392 +0200 > @@ -1,7 +1,7 @@ > [Unit] > Description=qcontrold > -Requires=dev-input-by\x2dpath-platform\x2dgpio_keys\x2devent.device > -After=dev-input-by\x2dpath-platform\x2dgpio_keys\x2devent.device > +Requires=dev-input-by\x2dpath- > platform\x2dgpio\x2dkeys\x2devent.device > +After=dev-input-by\x2dpath-platform\x2dgpio\x2dkeys\x2devent.device > # If the config file is there, we assume qcontrol works on this > machine. > ConditionPathExists=/etc/qcontrol.conf > > ---8<--- > > Thank you! > > -- System Information: > Debian Release: 9.9 > APT prefers oldstable-updates > APT policy: (500, 'oldstable-updates'), (500, 'oldstable') > Architecture: armel (armv5tel) > > Kernel: Linux 4.19.0-0.bpo.5-marvell > Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), > LANGUAGE=fr_FR.UTF-8 (charmap=UTF-8) > Shell: /bin/sh linked to /bin/dash > Init: systemd (via /run/systemd/system) > > Versions of packages qcontrol depends on: > ii libc6 2.24-11+deb9u4 > ii liblua5.1-0 5.1.5-8.1+b2 > ii udev 232-25+deb9u11 > > qcontrol recommends no packages. > > qcontrol suggests no packages. > > -- no debconf information >
