Le 13/08/2019 à 00:02, Daniel Baumann a écrit :
> Hi,
> thanks for fixing it.
> I see you've removed the '-i' passed to dh_link in override_dh_link.
> This is inferior to my suggested patch of replacing override_dh_link
> with override_dh_link_indep for the following reasons:
> 1. it overrides dh_link in all cases (arch-dep and indep) and thus
> (tries to) executes jdupes even when building arch-dep only
> (dpkg-buildpackage -B as commonly done on buildds), leading to this
> message during build:
> ---snip---
>    dh_perl -a
>    debian/rules override_dh_link
> make[1]: Entering directory '/build/apache2-2.4.39-2'
> dh_link
> jdupes -rl debian/apache2-doc/usr/share/doc
> could not stat dir debian/apache2-doc/usr/share/doc
> No duplicates found.
> make[1]: Leaving directory '/build/apache2-2.4.39-2'
>    dh_strip_nondeterminism -a
> ---snap---
> you got lucky that jdupes does not exit with 0 on non-existing paths,
> otherwise your build would have failed. I suggest not to leave this to
> chance that nobody ever fixes jdupes to exit with 1 in these cases, as
> it would be properly doing so in the first place.
> 2. creates *all* symlinks in debian/$package for all arch-dep packages
> too when build indep only. While a purely cosmetical thing (as the
> "speed" gain of not creating the symlinks is negligible, it clutters
> debian/* during build unecessarily and makes finding errors/debugging
> build things a tad more ugly.
> Therefore, please consider using override_dh_link_indep and pass '-i'
> again to dh_link, like my original patch:


when using "override_dh_link_indep", jdupes is launched before
apache2-doc is built, then nothing is cleaned in apache2-doc. That's why
I modified your patch


Reply via email to