Ian Jackson <ijack...@chiark.greenend.org.uk> writes:

> Sean Whitton writes ("Bug#935762: dgit: behaviour of --quilt=auto is 
> surprising when a quilt series exists"):
>> On Sun 25 Aug 2019 at 07:52PM -03, David Bremner wrote:
>> We talked about this a bit on IRC and it looks like what happened was
>> that David used --quilt=auto in repos which were patches-unapplied, so
>> dgit cannot reasonably be expected to have done the right thing.
>
> The result of that would be that dgit would make a .dsc with all the
> upstream changes reverted.  (Probably by making a new patch reverting
> them all.)
>

That matches my experience.

> That might help.  David, what did you expect --quilt=auto to do ?
> I ask because that may help us understand how to change the docs.

Indeed, for whatever reason I had the optimistic view that this would do
the right thing for both patches-unapplied or patches-applied. This was
just laziness on my part, backed up by the assumption that dgit would
fail if I did something really dumb.
>
> And, TBH I think --quilt=auto is not really useful enough to deserve
> that name.  Maybe it should be renamed to --quilt=try-linear or
> --quilt=linear+smash or something.  "auto" sounds like it
> automatically selects the right quilt mode which it very much doesn't
> (and which isn't possible, sadly).
>

The rename sounds reasonable to me.

Reply via email to