Bug#935935: golang-golang-x-sys: test failure in chroots

[Gianfranco Costamagna]

Source: golang-golang-x-sys
Version: 0.0~git20190726.fc99dfb-1
Severity: important
Tags: patch

Hello, while debugging a test failure in Ubuntu and pbuilder chroots, I found 
that the issue is also in Debian chroots (at lest in pbuilder environments), so 
you might want to disable it too for people not using sbuild.

not sure what happens, but the test is never run in sbuild because of missing 
capabilities, see e.g. the log from Debian builds:
(note: this is a new test, so previous versions never run such code)

=== RUN   TestOpenByHandleAt
=== RUN   TestOpenByHandleAt/clone=false
=== RUN   TestOpenByHandleAt/clone=true
--- PASS: TestOpenByHandleAt (0.00s)
    syscall_linux_test.go:559: mountID: 495, handle: size=12, type=1, 
bytes="\x99Zp\x90\r\x80\xad\x01\x00\x00\x00\x00"
    --- SKIP: TestOpenByHandleAt/clone=false (0.00s)
        syscall_linux_test.go:544: skipping open_by_handle_at test without 
CAP_DAC_READ_SEARCH
    --- SKIP: TestOpenByHandleAt/clone=true (0.00s)
        syscall_linux_test.go:544: skipping open_by_handle_at test without 
CAP_DAC_READ_SEARCH

While on Ubuntu:
=== RUN   TestOpenByHandleAt
--- FAIL: TestOpenByHandleAt (0.00s)
    syscall_linux_test.go:559: mountID: 29, handle: size=8, type=1, 
bytes="\x8eQ\x02\x00\f\xa4\x8ah"
    syscall_linux_test.go:563: openMountByID: mountID not found



cat /proc/self/mountinfo 
749 29 0:4 / /proc rw,relatime shared:611 - proc /proc rw
768 29 0:21 / /sys rw,nosuid,nodev,noexec,relatime shared:685 - sysfs sysfs rw
1092 29 0:69 / /dev/shm rw,relatime shared:755 - tmpfs tmpfs rw
1137 29 0:70 / /dev/pts rw,nosuid,noexec,relatime shared:766 - devpts devpts 
rw,gid=5,mode=620,ptmxmode=666
1159 29 0:70 /ptmx /dev/ptmx rw,nosuid,noexec,relatime shared:766 - devpts 
devpts rw,gid=5,mode=620,ptmxmode=666
1174 29 0:22 /9 /dev/console rw,nosuid,noexec,relatime shared:3 - devpts devpts 
rw,gid=5,mode=620,ptmxmode=000


I'm currently ignoring it with the following "patch"
--- golang-golang-x-sys-0.0~git20190726.fc99dfb.orig/unix/syscall_linux_test.go
+++ golang-golang-x-sys-0.0~git20190726.fc99dfb/unix/syscall_linux_test.go
@@ -539,6 +539,7 @@ func TestClockNanosleep(t *testing.T) {
 }

 func TestOpenByHandleAt(t *testing.T) {
+       t.Skip("cannot parse correctly /proc/self/mountinfo on chroots, 
ignoring test")
        skipIfNotSupported := func(t *testing.T, name string, err error) {
                if err == unix.EPERM {
                        t.Skipf("skipping %s test without CAP_DAC_READ_SEARCH", 
name)


Do you have any idea?

thanks

Gianfranco