Thank you for your work, Hans!

I shall upload the fixed package shortly.

Best regards,                   Georges.

Helmut Grohne a écrit :
> Source: partclone
> Version: 0.3.13+dfsg-1
> Tags: patch
> User: [email protected]
> Usertags: ftcbfs
> 
> partclone fails to cross build from source, because it does not pass
> --host to ./configure. The actual failure mode is very bad though: The
> missing --host flag causes pkg-config to not find uuid, whose else
> branch simply says "exit". That makes configure exit successfully
> without creating a Makefile. Consequently dh skips dh_auto_build. This
> is bad. Having it fail early and loudly would be very useful here.
> 
> With --host, things go much better, but it still misses the actual uuid
> flags, because it ignores the ones discovered and runs the wrong
> pkg-config instead. The attached patch fixes all of this. Please
> consider applying it. Also consider using AC_MSG_ERROR in place of
> "exit".
> 
> Helmut

> diff --minimal -Nru partclone-0.3.13+dfsg/debian/changelog 
> partclone-0.3.13+dfsg/debian/changelog
> --- partclone-0.3.13+dfsg/debian/changelog    2019-08-26 14:37:10.000000000 
> +0200
> +++ partclone-0.3.13+dfsg/debian/changelog    2019-08-27 20:38:00.000000000 
> +0200
> @@ -1,3 +1,12 @@
> +partclone (0.3.13+dfsg-1.1) UNRELEASED; urgency=medium
> +
> +  * Non-maintainer upload.
> +  * Fix FTCBFS: (Closes: #-1)
> +    + Let dh_auto_configure pass --host to ./configure.
> +    + cross.patch: Don't hard code the build architecture pkg-config
> +
> + -- Helmut Grohne <[email protected]>  Tue, 27 Aug 2019 20:38:00 +0200
> +
>  partclone (0.3.13+dfsg-1) unstable; urgency=medium
>  
>    * New upstream version 0.3.13
> diff --minimal -Nru partclone-0.3.13+dfsg/debian/patches/cross.patch 
> partclone-0.3.13+dfsg/debian/patches/cross.patch
> --- partclone-0.3.13+dfsg/debian/patches/cross.patch  1970-01-01 
> 01:00:00.000000000 +0100
> +++ partclone-0.3.13+dfsg/debian/patches/cross.patch  2019-08-27 
> 20:38:00.000000000 +0200
> @@ -0,0 +1,13 @@
> +--- partclone-0.3.13+dfsg.orig/configure.ac
> ++++ partclone-0.3.13+dfsg/configure.ac
> +@@ -55,8 +55,8 @@
> + fi
> + 
> + dnl Check for uuid 
> +-PKG_CHECK_MODULES(UUID, uuid,,exit)
> +-uuidcfg=`pkg-config --cflags --libs uuid`
> ++PKG_CHECK_MODULES(UUID, uuid,,exit 1)
> ++uuidcfg="$UUID_CFLAGS $UUID_LIBS"
> + 
> + AC_ARG_ENABLE([fuse],
> +     AS_HELP_STRING(
> diff --minimal -Nru partclone-0.3.13+dfsg/debian/patches/series 
> partclone-0.3.13+dfsg/debian/patches/series
> --- partclone-0.3.13+dfsg/debian/patches/series       2019-08-26 
> 14:36:41.000000000 +0200
> +++ partclone-0.3.13+dfsg/debian/patches/series       2019-08-27 
> 20:38:00.000000000 +0200
> @@ -1,3 +1,4 @@
>  config-stuff.patch
>  reiserfsclone.patch
>  no-pie.patch
> +cross.patch
> diff --minimal -Nru partclone-0.3.13+dfsg/debian/rules 
> partclone-0.3.13+dfsg/debian/rules
> --- partclone-0.3.13+dfsg/debian/rules        2019-08-26 14:36:41.000000000 
> +0200
> +++ partclone-0.3.13+dfsg/debian/rules        2019-08-27 20:38:00.000000000 
> +0200
> @@ -18,7 +18,7 @@
>  
>  override_dh_auto_configure:
>       ./autogen
> -     ./configure --prefix=$(DESTDIR)/usr --enable-ncursesw --enable-all
> +     dh_auto_configure -- --prefix=$(DESTDIR)/usr --enable-ncursesw 
> --enable-all
>  
>  override_dh_clean: # keep the special file fail-mbr/fail-mbr.bin.orig
>       dh_clean


-- 
Georges KHAZNADAR et Jocelyne FOURNIER
22 rue des mouettes, 59240 Dunkerque France.
Téléphone +33 (0)3 28 29 17 70

Attachment: signature.asc
Description: PGP signature

Reply via email to