Hi Simon, On Mon, 2 Sep 2019 10:53:32 +0100, Simon McVittie <[email protected]> wrote: > Without libglib2.0-dev installed, invoking > `pkg-config --cflags --libs libgcab-1.0` will fail. See attached patch > 0001 for the obvious fix. > > Please consider adding a superficial autopkgtest: this is easy to do > for -dev packages, and proves that the development library can be used > successfully. See attached patch 0002. I've been adding these to GNOME > team libraries, and started writing one for gcab before I realised it > wasn't a GNOME-team-maintained library :-)
Thanks, this and the follow-up patch are great, adding (good) autopkgtests is fantastic! Regarding the latter point, it would probably make sense for gcab to be GNOME-team-maintained, but we can sort that out later... > (A more involved autopkgtest using gcab-self-test requires upstream > changes, which I'll propose separately.) I’ve applied everything, thanks again. Regards, Stephen
pgpXvIDYnuvg4.pgp
Description: OpenPGP digital signature
