Source: xen Source-Version: 4.11.1+92-g6c33308a8d-2 Severity: normal Hi!
During the debhelper recommendation thread there was a mail from Ian pointing out to the xen debian/rules file, I took a look and noticed the following. :) The debian/rules file is setting DEB_BUILD_MAINT_OPTIONS with export to enable all hardening features. Subsequently it sets various build flags via a $(shell ) make construct, which is known to be unable to take export'ed make variables into account. This means the non-default options will not get enabled. The correct way to do this is to set the variables explicitly in $(shell ) calls or alternatively the easier way might be to use dpkg's buildflags.mk make fragment, which already deals with this. (While we are at it, the reason the hardening option does not enable all features by default, is because some might incur silent breakage which would not be acceptable to enable by default w/o involving the maintainer. There's also a trailing x on that comment, also there is s/it other/in other/ in another comment. :) The dh_installinit calls include update-rc.d arguments for runlevels which end up producing warnings at configure time. This are unneeded and can be safely removed, these are already covered by the LSB init metadata. Thanks, Guillem