Hi, Paul Wise kirjoitti 8.9.2019 klo 11.34: > On Sun, 2019-09-08 at 08:41 +0000, Eugene V. Lyubimkin wrote: > >> * debian/patches: >> - 0001-Increase-space-for-item-count-in-loading-screen: added >> (cherry-picked from upstream). (Closes: #931444) > > This just increases the size of the hardcoded space available so I > don't think it is the correct fix, since a larger item count will just > overflow the space again. It would be best to dynamically allocate it > based on the size of the item count/etc.
Yes, the upstream went for a quick fix here. There are other places, too [1], where it would be beneficial to use runtime-determined sizes instead of the fixed-width approach, but the upstream hasn't gone into that direction so far. I've marked the bug resolved, as the immediate problem reported is fixed. Plus, there is a natural limit of how many files one can have before ncdu stops to be usable, so in this particular case the maximum width approach sounds okay [2]. Feel free to re-open this bug, if you're willing to convince upstream otherwise. [1] https://code.blicky.net/yorhel/ncdu/issues/37 [2] even though I'd myself allow 2-3 more digits than today. Regards, -- Eugene V. Lyubimkin aka JackYF C++ GNU/Linux userspace developer, Debian Developer
