tag 892230 fixed-upstream tag 892421 fixed-upstream tag 927452 fixed-upstream thanks
Thanks for this and for your related reports #892421 and #927452. I've dealt with these all in one go, as they cover largely similar ground, and the fact that these pages are translated means that it's better to apply the same changes to everything at once where possible in order that translators have less work to do. On Wed, Mar 07, 2018 at 01:10:18AM +0000, Bjarni Ingi Gislason wrote: > Test nr. 1: Remove space at end of lines to simplify other automatic tests to > improve > typesetting. I applied this to all man-db's manual pages in one go. https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=44ec6b98ebfc8f667d3c4f75992544021d733fc0 > Test nr. 24: > Change a HYPHEN-MINUS (code 0x55, 2D) to a minus (\-), if in front of a > name for an option. > > 1110:.I groff -mandoc > 1167:.I groff -mandoc Your patch was against the generated page, but this part of the page comes from values computed by configure, so it required a bit more work: https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=0fdc8e921622d3614c22082a6934548e4a161bbc > Test nr. 27: Split lines longer than 80 characters into two or more > lines. > > man.1: line 170 length 108 > man.1: line 1232 length 85 Similarly, this part of the page is generated based on configure output, so I took a different approach: https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=9d96b22859d7a3f532690bc87b743667be048f5c > Test nr. 30: Surround a block of comments with the macros ".ig" and "..". > The .\" at the beginning of each line is then not needed. > Makes it easier to add and remove text and adjust lenght of lines I chose not to bother with this, although I deleted some block comments as a result of other changes. Most of the comments in question change extremely rarely so I've never found it an inconvenience, and of course it has no effect on the output either way. I might take this approach for any block comments I add in the future. On Fri, Mar 09 2018 at 00:22:39AM +0000, Bjarni Ingi Gislason wrote: > Use a macro to change to the italic font, instead of \fI [1], if > possible. > The macros have the italic corrections, but "\c" removes them. > [1] man-pages(7) > > 104:\fB\-s\fP \fIlist\fP, \fB\-\-sections\fP \fIlist\fP, \fB\-\-section\fP > \fIlist\fP I had to take a somewhat different approach here and for similar changes in #927452 to pacify po4a, whose parser doesn't always quite manage to cope with more complex troff programming techniques; and I took the same approach for the same options consistently across all man-db's manual pages: https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=57fcd4f1ea201074aef9437c407efde6b26247fb I think the extra italic correction after --systems=system is unnecessary given the following \|, but please let me know if this is wrong. I couldn't figure out a formatting pipeline where I could see any difference. I applied the remainder of your patches here: https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=d84bb1a3586dfca2389eed428c11bde7225ceb0b https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=f876af69a2b53242a39febdc531c811d60dfa90a https://git.savannah.gnu.org/cgit/man-db.git/commit/?id=7604d2695f86922d9981186d7fc49c4c635aadd4 Thanks, -- Colin Watson [[email protected]]
