Package: git-debpush
Version: 9.9
Severity: important

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Dear Maintainer,

In line 61, grep -Eq may cause a pipefail if grep exits before git
ls-tree concludes. With a debug print for $? I can see this:

    ++ get_file_from_ref debian/source/format
    ++ local path=debian/source/format
    ++ git ls-tree --name-only -r refs/heads/debian/buster-security
    ++ grep -Eq '^debian/source/format$'
    ++ echo @@@@ 141

It helped when I replaced it with a redirect:

    if git ls-tree --name-only -r "$branch" \
            | grep -E "^$path$" >/dev/null; then
        git cat-file blob $branch:$path
    fi

++ local path=debian/source/format
++ git ls-tree --name-only -r refs/heads/debian/buster-security
++ grep -E '^debian/source/format$'
++ echo @@@@ 0

- -- 
Cheers,
  Andrej

-----BEGIN PGP SIGNATURE-----

iQFIBAEBCAAyFiEEeuS9ZL8A0js0NGiOXkCM2RzYOdIFAl2AtGwUHGFuZHJld3No
QGRlYmlhbi5vcmcACgkQXkCM2RzYOdJwAAgAlMAsuhQhpGGCWA5OXGfbhBIG3yT/
rwHjpo+qtiC2HJVOTkrS7NtP6CSDC+alxvBTfamLG2qtnbNR4ddk5z3AfHTPxoNL
ZlE/3n3qqTHe4G0YGSY925aoR09okxRa/mjagIlKqDwg45xdE2W9ZdtkStipFno2
mPbvCzmzKo+XToXKpzOi4wRgbZcnFeum1U4qezHdKhSRApRmuq95nQ+uIJfbVrt4
Rn7ewarbvJFHsBXotVaX/rHWvxpzNlWBVQZYR5Bq7Y8wunEF6iY2Hxxq7MxAXkg4
DuUCtLbjpkHI1DGZKKm+6zcCKGaMAG3BGvuHqEy/IWwGbwkjDEoKtLo4kQ==
=/dwb
-----END PGP SIGNATURE-----

Reply via email to