Yes, that's one possible fix.
But if you grab a newer version from upstream, pointer_deref_comparison.patch
isn't necessary at all. The change from '\0' to NULL was already made 2018-09-19
as I described above in message #5 on this report.
I suppose grabbing the newer version make sense in the long term,
but fixing pointer_deref_comparison.patch makes sense as a quick
fix for current releases.
(Sorry if I'm stating the obvious.)
On Fri, Sep 20, 2019 at 6:51 PM Graham Inggs <gin...@debian.org> wrote:
>
> Modifying pointer_deref_comparison.patch as follows works for me.
>
>
> --- a/debian/patches/pointer_deref_comparison.patch
> +++ b/debian/patches/pointer_deref_comparison.patch
> @@ -5,7 +5,7 @@
> }
> if (alvec) {
> - if ((alvecp = *alvec) != '\0') {
> -+ if (*(alvecp = *alvec) != '\0') {
> ++ if ((alvecp = *alvec) != NULL) {
> alvec++;
> goto top;
> }
> @@ -14,7 +14,7 @@
> reset();
> }
> - if ((evalp = *evalvec) != '\0') {
> -+ if (*(evalp = *evalvec) != '\0') {
> ++ if ((evalp = *evalvec) != NULL) {
> evalvec++;
> goto top;
> }
>
> --
> To unsubscribe, send mail to 933057-unsubscr...@bugs.debian.org.
