Forwarding this relatd post from the gnuradio mailing list. ---- From: Michael Dickens <[email protected]> To: Harald Welte <[email protected]> Cc: GNURadio Discussion List <[email protected]>, "A. Maitland Bottoms" <[email protected]>, Pau Espin Pedrol <[email protected]> Subject: Re: [Discuss-gnuradio] UHD / -lboost_system / pkg-config / Debian patch
Hi Harald - Mait & I talked about this issue during GRCon19 a few weeks ago. I believe we came to the same conclusions as you note: A project that does not otherwise require non-UHD library/ies should not have to know to link against them (nor how). The linkage should be provided transparently by CMake or pkgconfig or whatever: variables are returned from "find"ing UHD that provides CFLAGS, CXXFLAGS, LDFLAGS, LIBRARIES, LIBRARY_DIRS, INCLUDE_DIRS, and so forth. These variables can then be used as-is by the calling project without having to know anything else about how the API or ABI is built, installed, or used beyond these variables. The correct way to do this varies depending on which "find" is used. For pkgconfig, using "Requires.private" or "Requires" or just leaving the linkage as before the patch ... any of those might work. But, yes, the bottom line is that the patch you note isn't doing the right thing and needs to be either fixed or removed. I'm leaving it to Mait to deal with this as he sees fit; I think we'd all prefer this get done sooner rather than later. - MLD ---- -- - Harald Welte <[email protected]> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)
