Control: tags -1 patch

Hi!

On Thu, 2019-09-05 at 16:27:38 -0400, Dan Streetman wrote:
> Having a custom rule to create 'configure' means that if the file
> may not get correctly rebuilt; instead dh_autoreconf should be
> called to make sure it is always correctly rebuilt.

Thanks for the patch!

I tend to agree that running autoreconf during build is best practice
in general, as that makes it possible to introduce new arch support in
most of the archive (config.sub & config.guess updates) w/o needing to
touch thousands of packages. Or pick up new autotools fixes. In some
cases it might also help if a downstream modifies the build system.

My general reluctance to not do that for dpkg (a native package), has
been so that in case its autotools support, as released, is too old,
we'd get bug reports requesting an update. Also because any new arch
support requires explicit support in dpkg itself anyway.

I suspect your actual problem might stem from someone having modified
the configure.ac after having modified the release date in the
debian/changelog, so that on unpack the timestamps get clamped and
then the build system cannot know it needs to regen the file.


But, given that I don't even recall a single instance of someone
reporting the released autotools stuff being out-of-date, that most
downstreams might not even be Debian/dpkg-based distributions, and
that not regenerating it on each build can easily cause problems on
Debian/dpkg-derived downstreams, I'm inclined to just merge your patch.

Thanks,
Guillem

Reply via email to