severity 358689 grave
thanks

(raised the bug severity by request of the maintainer)

Hi,

As I told the package maintainer by IRC, I tried to search the code
for the possible culprit of this malfunction - I am _way_ too bad in C
(and, of course, working with XS) to come up with a patch for this,
and am unfamiliar with Apache::Request internals, but I think I found
a possible cause. 

The patch between 2.04-dev-1 and 2.04-dev-1sarge1 lies mostly in
putting the 'nlen' and 'vlen' values inside the different ctx
structs - Most of the patch's hunks have this change. I noticed line
541 of apreq_parsers.c reads:

                    s = split_header(t, ctx->bb, ctx->nlen, glen, vlen);

note that it still has vlen as a straight argument, instead of using
ctx->vlen as mostly everywhere else. A couple of lines past it you
will find vlen being used as one of ctx's members, resetting it to
zero: 

                    ctx->vlen = 0;

On the other hand, I found a second possible culprit: The only other
place I found reference to nlen/vlen is in the Perl glue -
Specifically, in glue/perl/xsbuilder/Apache/Upload/Apache__Upload.h
function apreq_xs_upload_make, where both are declared and
used. Probably, if they changed from being independent variables to
becoming members of a structure, they should change as well in the
Perl glue part.

As I said, this is just guesswork, I basically did an eye-based
pattern matching; I think the problem lies in the first hypothesis,
but both are possible.

Thanks for looking into it!

-- 
Gunnar Wolf - [EMAIL PROTECTED] - (+52-55)5623-0154 / 1451-2244
PGP key 1024D/8BB527AF 2001-10-23
Fingerprint: 0C79 D2D1 2C4E 9CE4 5973  F800 D80E F35A 8BB5 27AF


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to