Hi Chris,
On 22 October 2019 at 15:46, Chris Lamb wrote: | Source: r-base | Version: 3.6.1-6 | Severity: normal | Tags: patch | | Hi, | | src:r-base does not appear to respect the "nocheck" profile in | DEB_BUILD_OPTIONS. Whilst there appears to be code that intends to do | exactly this, ie.: | | build-arch: make-arch | ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) | build-arch: check | endif | | … AFAICT this does not work as we specify "check" directly in the | binary target: | | binary: make-stamp check binary-arch binary-indep | | However, a patch is attached that drops the puts all of the "shall I | actually run the tests" predicates together which not only works (!) | it also is a bit clearer. | | Discovered as part of faffing around with Reproducible Builds [0]. | | [0] https://reproducible-builds.org/ Big big BIG thank you. I noticed the 'no repro for you' checkmark the other day when scanning my QA page. It may be a side effect of the recent switch to source-only uploads which affected the doc packages (and I had to cheat and make binary-arch build binary-all builds -- it depends on configure and friends doing their thing). Will fold this in this evening. Happy to assist with the other missing 'no repro for you' on my page at https://qa.debian.org/[email protected] but may need help. If you can spare a few more moments I would appreciate it. If you're tied up no mas. Cheers, Dirk -- http://dirk.eddelbuettel.com | @eddelbuettel | [email protected]
