Package: runit
Version: 2.1.2-35
Severity: wishlist
Tags: patch

Hi,

while doing another round of testing with openssh-server i've found some
minor problem that might need a fix.
Detailed description is in git commit message.

Lorenzo

-- System Information:
Debian Release: bullseye/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 4.20.3-van (SMP w/4 CPU cores; PREEMPT)
Kernel taint flags: TAINT_OOT_MODULE
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_US:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: runit (via /run/runit.stopit)

Versions of packages runit depends on:
ii  libc6           2.29-2
ii  sysuser-helper  1.3.3

Versions of packages runit recommends:
ii  runit-init  2.1.2-35

runit suggests no packages.

-- Configuration Files:
/etc/default/runit changed [not included]
/etc/runit/3 changed [not included]

-- no debconf information

-- debsums errors found:
debsums: changed file /lib/runit/invoke-run (from runit package)
debsums: changed file /sbin/update-service (from runit package)
>From bb212cbba9d01476f4a9c29a81c07e7c922c078f Mon Sep 17 00:00:00 2001
From: Lorenzo Puliti <lorenzo.r...@gmail.com>
Date: Thu, 24 Oct 2019 11:59:05 +0200
Subject: [PATCH 2/2] minor improvements to invoke-run

* be verbose about uninstalled binary
* fix indentation in previous patch [1d28c60d] replacing spaces with TAB
* redirect output of {$initscripts} stop to /dev/null (it goes to
  service log otherwise); it is confusing to see a stop message during
  service startup
---
 debian/contrib/lib/invoke-run | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/debian/contrib/lib/invoke-run b/debian/contrib/lib/invoke-run
index 2a11306..54e6d47 100755
--- a/debian/contrib/lib/invoke-run
+++ b/debian/contrib/lib/invoke-run
@@ -38,15 +38,16 @@ if [ -f "/etc/sv/${service}/.meta/installed" ] ; then
        # uninstalled, but not purged. See #929693 and commit [4c485b]
        # in dh-runit repository.
        if ! [ -f "${installed}" ] ; then
+               echo "runsv: $NAME binary not installed"
                sv down "${service}"
                exit 0
        fi
 fi
 
 if [ -r /etc/default/runit ]; then
-    set -a
-    . /etc/default/runit
-    set +a
+       set -a
+       . /etc/default/runit
+       set +a
 fi
 
 if [ -r "/etc/default/${service}" ] ; then
@@ -69,7 +70,7 @@ if [ -x "${initscript}" ] ; then
                        exit 0
                fi
        fi
-       "${initscript}" stop
+       "${initscript}" stop >/dev/null
 fi
 
 if [ -d "/etc/sv/${service}/conf" ] ; then
-- 
2.24.0.rc0

Reply via email to