Package: python3-crypto Version: 2.6.1-12+b1 Severity: normal Tags: patch Hi,
I got the following errors when upgrading the package: /usr/lib/python3/dist-packages/Crypto/Random/Fortuna/FortunaGenerator.py:28: SyntaxWarning: "is" with a literal. Did you mean "=="? if sys.version_info[0] is 2 and sys.version_info[1] is 1: /usr/lib/python3/dist-packages/Crypto/Random/Fortuna/FortunaGenerator.py:28: SyntaxWarning: "is" with a literal. Did you mean "=="? if sys.version_info[0] is 2 and sys.version_info[1] is 1: /usr/lib/python3/dist-packages/Crypto/SelfTest/Random/test_random.py:107: SyntaxWarning: "is" with a literal. Did you mean "=="? if sys.version_info[0] is 3: The attached patch fixes them. Cheers Jochen -- System Information: Debian Release: bullseye/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 5.3.0-2-amd64 (SMP w/8 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8), LANGUAGE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) LSM: AppArmor: enabled Versions of packages python3-crypto depends on: ii libc6 2.29-3 ii libgmp10 2:6.1.2+dfsg-4 ii python3 3.7.5-3 python3-crypto recommends no packages. python3-crypto suggests no packages. -- no debconf information
From: Jochen Sprickerhof <[email protected]> Date: Sat, 16 Nov 2019 08:36:09 +0100 Subject: Use == for int compare --- lib/Crypto/Random/Fortuna/FortunaGenerator.py | 2 +- lib/Crypto/SelfTest/Random/test_random.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Crypto/Random/Fortuna/FortunaGenerator.py b/lib/Crypto/Random/Fortuna/FortunaGenerator.py index 723fa63..d31261e 100644 --- a/lib/Crypto/Random/Fortuna/FortunaGenerator.py +++ b/lib/Crypto/Random/Fortuna/FortunaGenerator.py @@ -25,7 +25,7 @@ __revision__ = "$Id$" import sys -if sys.version_info[0] is 2 and sys.version_info[1] is 1: +if sys.version_info[0] == 2 and sys.version_info[1] == 1: from Crypto.Util.py21compat import * from Crypto.Util.py3compat import * diff --git a/lib/Crypto/SelfTest/Random/test_random.py b/lib/Crypto/SelfTest/Random/test_random.py index f9ffc66..c22a8cd 100644 --- a/lib/Crypto/SelfTest/Random/test_random.py +++ b/lib/Crypto/SelfTest/Random/test_random.py @@ -104,7 +104,7 @@ class SimpleTest(unittest.TestCase): for i in range(10): self.assertEqual(random.choice((1,2,3)) in (1,2,3), True) self.assertEqual(random.choice([1,2,3]) in [1,2,3], True) - if sys.version_info[0] is 3: + if sys.version_info[0] == 3: self.assertEqual(random.choice(bytearray(b('123'))) in bytearray(b('123')), True) self.assertEqual(1, random.choice([1])) self.assertRaises(IndexError, random.choice, [])
