Control: tags -1 + fixed-upstream

TL;DR drop leftover python from Recommends should trivially solve this!

Hello,

So given this package has high popcon it seemed like it deserved someone
looked at it. Apparently upstream already supports either python2 or
python3.

The python3 support comes in the form of an officially supported way to
convert the sources at build-time, see:
https://github.com/fail2ban/fail2ban/blob/0.11/fail2ban-testcases-all-python3

And for tests, see also:
https://github.com/fail2ban/fail2ban/blob/0.11/fail2ban-testcases-all-python3

Apparently this is already in use by the debian package which also
explicitly disables python2!

The reason for this bug report should be listed in
https://people.debian.org/~morph/mass-bug-py2removal_take3.txt
which says:
fail2ban 0.10.2-2.1 ['(binary:fail2ban)Recommends->python']

This is what debian/changelog has to say about the reason for python(2)
being in Recommends:

"Added regular python to Recommends since apache-fakegooglebot still python2"

This however doesn't seem to be true anymore:

$ head -n 1 fail2ban-0.10.2/config/filter.d/ignorecommands/apache-fakegooglebot 
#!/usr/bin/env fail2ban-python
$ dpkg -x fail2ban_0.10.2-2.1_all.deb f
ls -l f/usr/bin/fail2ban-python 
lrwxrwxrwx 1 ah ah 7 Sep 23  2018 f/usr/bin/fail2ban-python -> python3
$ head -n 1 f/etc/fail2ban/filter.d/ignorecommands/apache-fakegooglebot
#!/usr/bin/env fail2ban-python

So my conclusion is that the recommends is obsolete and can simply be
dropped, which should be the last nail in the coffin and this bug report
can be closed!

Regards,
Andreas Henriksson

Reply via email to