Le mardi 10 décembre 2019 à 12:27:35-0700, Daniele Nicolodi a écrit : > Hello, > > On Tue, 26 Nov 2019 13:06:24 +0100 "Dr. Tobias Quathamer" > <to...@debian.org> wrote:> I've forwarded this bug upstream, and further > investigation by them > > seems to indicate that this is actually a bug in CPython. > > > > I'm therefore cloning and reassigning this bug, feel free to > > revert this if you don't agree. > > A while ago I opened a merge request with upstream with a workaround > that fixes the segfault with CPython 3.8. As it seems that CPython 3.8.1 > will be released with the bug not fixed, it may be worth to apply the > patch to the Debian package. > > https://bitbucket.org/blais/beancount/pull-requests/139 > > All the patch does is to make the C code Python 3.9 ready, avoiding > raising a warning, which ultimately results in the segfault. The patch > seems very low risk to me.
Dear Daniele, Thanks for the patch. I adapted it a little to reduce it's volume: https://salsa.debian.org/python-team/applications/beancount/blob/debian/master/debian/patches/0003-parser-Work-around-python3.8-bug-causing-a-segmentat.patch The #define PY_SSIZE_T_CLEAN was in both parser.h and parser.c, and the removal of the two other includes seems out of scope for this bugfix IMO. Is it fine with you? Cheers! -- Pierre-Elliott Bécue GPG: 9AE0 4D98 6400 E3B6 7528 F493 0D44 2664 1949 74E2 It's far easier to fight for one's principles than to live up to them.
signature.asc
Description: PGP signature